docs(governance): frame PRs as "push requests" — problem-first evaluation#62
Merged
Conversation
…tion Refines the OSS contribution docs around the mindset that a pull request is a request to push a change, evaluated by "what problem does this solve?" before the diff. - PR template: leads with "What problem does this solve?" (was "what does this PR do?"); adds a DCO sign-off checklist item. - CONTRIBUTING.md: new "How we evaluate a PR" section — the 5-rung ladder (problem -> scope -> solution -> verifiable -> governance); line-by-line review comes after the top three. - ADR 010: adds decision 9 (Problem-First PR Triage) codifying the ladder as the governance evaluation procedure, so review is consistent and delegable. Docs-only; no code or product change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012wU47GVzskAummZqgH6FgF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
Our OSS contribution docs were strong on process (branch protection, DCO, CI gates, merge strategy, timelines) but silent on the substance lens — how a PR is actually judged. The PR template asked "what does this PR do?" (code-first), and the evaluation order wasn't written down anywhere, so it had to be re-derived per PR and couldn't be cleanly delegated or handled autonomously.
What this changes
Reframes contribution around the idea that a PR is a request to push a change, read from the problem down rather than the diff up:
Docs-only — no code or product change, so no version bump or changelog entry.
🤖 Generated with Claude Code
https://claude.ai/code/session_012wU47GVzskAummZqgH6FgF