ci: automate code formatting and linting with git hooks

Author: ns-vasilev

.github/workflows/ci.yml

@@ -23,16 +23,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  SwiftLint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v5
-      - name: GitHub Action for SwiftLint
-        uses: norio-nomura/action-swiftlint@3.2.1
-        with:
-          args: --strict
-        env:
-          DIFF_BASE: ${{ github.base_ref }}
   macOS:
     name: ${{ matrix.name }}
     runs-on: ${{ matrix.runsOn }}
@@ -205,23 +195,3 @@ jobs:
         with:
           name: MergedResult
           path: test_output/final
-
-  discover-typos:
-    name: Discover Typos
-    runs-on: macos-15
-    env:
-      DEVELOPER_DIR: /Applications/Xcode_16.4.app/Contents/Developer
-    steps:
-      - uses: actions/checkout@v5
-
-      - name: Set up Python environment
-        run: |
-          python3 -m venv .venv
-          source .venv/bin/activate
-          pip install --upgrade pip
-          pip install codespell
-
-      - name: Discover typos
-        run: |
-          source .venv/bin/activate
-          codespell --ignore-words-list="hart,inout,msdos,sur" --skip="./.build/*,./.git/*"

.github/workflows/lint.yml

@@ -0,0 +1,45 @@
+name: lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    paths:
+      - "Sources/**"
+      - ".github/workflows/ci.yml"
+      - "Tests/**"
+
+concurrency:
+  group: lint-${{ github.head_ref }}
+  cancel-in-progress: true
+
+jobs:
+  lint:
+    name: lint
+    runs-on: macos-15
+    steps:
+      - uses: actions/checkout@v5
+      - uses: jdx/mise-action@v3
+      - name: Run
+        run: mise run lint
+
+  discover-typos:
+    name: discover-typos
+    runs-on: macos-15
+    env:
+      DEVELOPER_DIR: /Applications/Xcode_16.4.app/Contents/Developer
+    steps:
+      - uses: actions/checkout@v5
+
+      - name: Set up Python environment
+        run: |
+          python3 -m venv .venv
+          source .venv/bin/activate
+          pip install --upgrade pip
+          pip install codespell
+
+      - name: Discover typos
+        run: |
+          source .venv/bin/activate
+          codespell --ignore-words-list="hart,inout,msdos,sur" --skip="./.build/*,./.git/*"

Makefile

@@ -259,7 +259,7 @@ dependencies: [
 Bootstrapping development environment
 
 ```
-make bootstrap
+mise install
 ```
 
 Please feel free to help out with this project! If you see something that could be made better or want a new feature, open up an issue or send a Pull Request!

Mintfile

@@ -9,11 +9,11 @@ extension ValidationResult: Equatable {
     public static func == (lhs: ValidationResult, rhs: ValidationResult) -> Bool {
         switch (lhs, rhs) {
         case (.valid, .valid):
-            return true
+            true
         case let (.invalid(errors: lhs), .invalid(errors: rhs)):
-            return lhs.map(\.message).joined() == rhs.map(\.message).joined()
+            lhs.map(\.message).joined() == rhs.map(\.message).joined()
         default:
-            return false
+            false
         }
     }
 }

README.md

@@ -21,7 +21,7 @@ public protocol IUIValidatable: AnyObject {
     ///   - rule: The validation rule.
     ///
     /// - Returns: A validation result.
-    func validate<T>(rule: some IValidationRule<T>) -> ValidationResult where T == Input
+    func validate(rule: some IValidationRule<Input>) -> ValidationResult
 
     /// Validates an input value.
     ///
@@ -71,7 +71,7 @@ public extension IUIValidatable {
                 self,
                 &kValidationRules,
                 newValue as [any IValidationRule<Input>],
-                .OBJC_ASSOCIATION_RETAIN_NONATOMIC
+                .OBJC_ASSOCIATION_RETAIN_NONATOMIC,
             )
         }
     }

Sources/ValidatorCore/Classes/Extensions/ValidationResult+Equatable.swift

@@ -28,7 +28,7 @@ public extension View {
     func validation<T>(
         _ item: Binding<T>,
         rule: some IValidationRule<T>,
-        action: @escaping (ValidationResult) -> Void
+        action: @escaping (ValidationResult) -> Void,
     ) -> some View {
         validation(item, rules: [rule], action: action)
     }
@@ -51,7 +51,7 @@ public extension View {
     func validation<T>(
         _ item: Binding<T>,
         rules: [any IValidationRule<T>],
-        action: @escaping (ValidationResult) -> Void
+        action: @escaping (ValidationResult) -> Void,
     ) -> some View {
         let result = validator.validate(input: item.wrappedValue, rules: rules)
         action(result)

Sources/ValidatorUI/Classes/IUIValidatable.swift

@@ -18,14 +18,14 @@ public extension View {
     func validate<T, ErrorView: View>(
         item: Binding<T>,
         rules: [any IValidationRule<T>],
-        @ViewBuilder content: @escaping ([any IValidationError]) -> ErrorView
+        @ViewBuilder content: @escaping ([any IValidationError]) -> ErrorView,
     ) -> some View {
         modifier(
             ValidationViewModifier(
                 item: item,
                 rules: rules,
-                content: content
-            )
+                content: content,
+            ),
         )
     }
 
@@ -38,13 +38,13 @@ public extension View {
     /// - Returns: A modified view.
     func validate<ErrorView: View>(
         validationContainer: any IFormValidationContainer,
-        @ViewBuilder content: @escaping ([any IValidationError]) -> ErrorView
+        @ViewBuilder content: @escaping ([any IValidationError]) -> ErrorView,
     ) -> some View {
         modifier(
             FormValidationViewModifier(
                 validationContainer: validationContainer,
-                content: content
-            )
+                content: content,
+            ),
         )
     }
 }

Sources/ValidatorUI/Classes/SUI/Extensions/View+Validation.swift

@@ -15,8 +15,8 @@ public typealias ValidationPublisher = AnyPublisher<ValidationResult, Never>
 public final class FormField<Value>: IFormField {
     // MARK: Properties
 
-    @Published
     /// The value to validate.
+    @Published
     private var value: Value
 
     /// The validation.
@@ -35,7 +35,7 @@ public final class FormField<Value>: IFormField {
     public init(
         wrappedValue: Value,
         validator: IValidator = Validator(),
-        rules: [any IValidationRule<Value>]
+        rules: [any IValidationRule<Value>],
     ) {
         value = wrappedValue
         self.validator = validator
@@ -57,7 +57,7 @@ public final class FormField<Value>: IFormField {
             value: subject,
             publisher: publisher,
             validator: validator,
-            rules: rules
+            rules: rules,
         )
 
         manager.append(validator: container)