Skip to content

(Try to) Fix a null reference exception in ComponentTreeSystem.UpdateTreePositions #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metalgearsloth merged 1 commit into from
Jun 26, 2026
+3 −3
Merged

(Try to) Fix a null reference exception in ComponentTreeSystem.UpdateTreePositions #6604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Robust.Shared/ComponentTrees/ComponentTreeSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@
{
(pos, rot) = XformSystem.GetRelativePositionRotation(
entry.Transform,
newTree!.Value);
newTree.Value);

newTreeComp!.Tree.Update(entry, ExtractAabb(entry, pos, rot));
newTreeComp?.Tree.Update(entry, ExtractAabb(entry, pos, rot));
continue;
}

Expand All @@ -258,7 +258,7 @@

(pos, rot) = XformSystem.GetRelativePositionRotation(
entry.Transform,
newTree!.Value);
newTree.Value);

newTreeComp.Tree.Add(entry, ExtractAabb(entry, pos, rot));
}
Expand Down Expand Up @@ -343,7 +343,7 @@
public HashSet<ComponentTreeEntry<TComp>> QueryAabb(MapId mapId, Box2Rotated worldBounds, bool approx = true)
{
var state = new HashSet<ComponentTreeEntry<TComp>>();
QueryAabb(state, mapId, worldBounds, approx);

Check warning on line 346 in Robust.Shared/ComponentTrees/ComponentTreeSystem.cs

View workflow job for this annotation

GitHub Actions / build (Linux) 

'ComponentTreeSystem<TTreeComp, TComp>.QueryAabb(HashSet<ComponentTreeEntry<TComp>>, MapId, Box2Rotated, bool)' is obsolete: 'Use Entity<T> variant'

Check warning on line 346 in Robust.Shared/ComponentTrees/ComponentTreeSystem.cs

View workflow job for this annotation

GitHub Actions / build (MacOS) 

'ComponentTreeSystem<TTreeComp, TComp>.QueryAabb(HashSet<ComponentTreeEntry<TComp>>, MapId, Box2Rotated, bool)' is obsolete: 'Use Entity<T> variant'

Check warning on line 346 in Robust.Shared/ComponentTrees/ComponentTreeSystem.cs

View workflow job for this annotation

GitHub Actions / build (Windows) 

'ComponentTreeSystem<TTreeComp, TComp>.QueryAabb(HashSet<ComponentTreeEntry<TComp>>, MapId, Box2Rotated, bool)' is obsolete: 'Use Entity<T> variant'

return state;
}
Expand Down
Loading