Fix: entity localization parent fallback#6718
Open
codebykoi wants to merge 7 commits into
Open
Conversation
… into fix/entity-localization-inheritance
Author
|
found another bug, fixing it rn |
Author
|
alright, added small tests, and added NeverPushInheritance attribute to the fields of EntityPrototype. |
Author
|
Test was failing because of the RCD, the recent commit should fixed the edge case when entity had no name at all, it just fallbacks to protoId instead |
Author
|
I have no idea why test failed on RandomSpecies test. I literalyl have nothing to do with it. |
Author
|
and here we go, all tests passes |
codebykoi
commented
Jul 4, 2026
|
|
||
| // LOCALIZATION NOTE: | ||
| // Localization-related properties in here are manually localized in LocalizationManager. | ||
| // As such, they should NOT be inherited to avoid confusing the system. |
Author
There was a problem hiding this comment.
its literally says here that fields should not be inherited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I working with a locale files for my fork, I found it troublesome when working with many different .ftl files, and my builds always were giving me errors about missing .desc and etc, not allowing me to run properly.
this PR its basically a QoL fixes when working with locales.
Keep in mind that its my first ever PR to RobustToolbox, so I may dont know some specific details about the codebase, but I hope this one works for everyone.