Chat Message Spacing Offset#6723
Open
Alecksohs wants to merge 2 commits into
Open
Conversation
Contributor
Does this fix this |
Author
|
This will not 'fix' the fundemental issues if the renderer's spacing being odd due to pixel alignment. It just allows you to, for every message, increase the total spacing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds a public message spacing offset variable to the Output Panel.
Technical details
The current chatbox renders using not controls but a bespoke custom drawpass with Rich Text Entries. This has an issue of pixel rounding on spacing, where at smaller font sizes, you will have issues regarding pixel spacing. A message spacing offset is added to the previous GetLineSeparation to add the float to the spacing. It's rather simple.
Breaking changes
None.