CVar for code source info#6749
Open
Fildrance wants to merge 5 commits into
Open
Conversation
Member
Author
|
After merge we will just going to need to add after
And ideally add display of this data somewhere in client UI :> |
Member
|
This should be handled by RobustCDN. build.json is also currently made by RobustCDN. |
Member
Author
|
@Simyon264 okay i found related code in CDN and changed it, changed RT code to only get more variables from build.json Can you point me to GHA that is posting to RobustCDN so i can add new arguments there? |
Member
|
It's publish.yml and publish-testing.yml iirc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug report feature would need full info on sources that were used to run current instance of application, at least server side.
Added script to put more sources info into cvar, and related cvars (well documented i feel).
build.hash already exists so no cvar for it.
As alternative to adding cvar data to
server_config.toml- i could addbuild.json. But it seems like its generation with it was removed some time ago, and i lack knowledge of why, so not touching it :|Also i am not editing client-side toml, relying on syncing kinda, but it is worth considering (for cases when somehow client will be reporting things and having separate version... not sure how we could end up in usch situation T_T).
Sample of scirpt run result: