EntitySystem.Spawn: defer MapInitEvent in SpawnNextTo/InContainer/...OrDrop#6784
Open
whatston3 wants to merge 3 commits into
Open
EntitySystem.Spawn: defer MapInitEvent in SpawnNextTo/InContainer/...OrDrop#6784whatston3 wants to merge 3 commits into
whatston3 wants to merge 3 commits into
Conversation
|
Similar to #6192 in what it accomplishes. |
Contributor
Author
Wasn't noted in the linked issue when it should've been. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
EntityManager.SpawnXfunctions so that the MapInitEvent is fired when the entity is on its target map, not nullspace.Why?
Will resolve this issue: space-wizards/space-station-14#41502
Without this, these Spawn functions are more or less useless for spawning spawners (that tend to run on MapInit).
Gives a stronger, more consistent guarantee of when the MapInitEvent will be run between Spawn commands.
Media
A demonstration of the issue in space-wizards/space-station-14#41502 being resolved, which uses SpawnNextToOrDrop:
get-crystal.mp4