Standardise roslyn on registercompilationstart#6818
Open
metalgearsloth wants to merge 2 commits into
Open
Conversation
Faster than the generic registeroperationaction
Contributor
Author
|
@Tayrtahn if my guardian angel is listening. |
Tayrtahn
approved these changes
Jul 18, 2026
Tayrtahn
left a comment
Tayrtahn
left a comment
Contributor
There was a problem hiding this comment.
I won't be able to actually test these changes for a bit, but this all looks good to me. Good stuff!
| if (preferGenericAttribute is null) | ||
| return; | ||
|
|
||
| var typeTypeSymbol = compilationContext.Compilation.GetTypeByMetadataName("System.Type"); |
Contributor
There was a problem hiding this comment.
'tis a bit silly, but make it a const string, please.
| context.RegisterOperationAction(Check, OperationKind.PropertyReference); | ||
| context.RegisterCompilationStartAction(compilationContext => | ||
| { | ||
| var taskType = compilationContext.Compilation.GetTypeByMetadataName("System.Threading.Tasks.Task`1"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faster than the generic registeroperationaction.
Builds noisy ah but in dummy runs was anywhere from a second to several seconds faster.