Create an OrganizedListSerializer to allow for sorting of YAML lists.#6827
Open
Princess-Cheeseballs wants to merge 3 commits into
Open
Create an OrganizedListSerializer to allow for sorting of YAML lists.#6827Princess-Cheeseballs wants to merge 3 commits into
Princess-Cheeseballs wants to merge 3 commits into
Conversation
Member
Author
|
I hate the names I chose but I'm too eepy to think of better ones. First come first serve to bikeshed my naming conventions. |
metalgearsloth
requested changes
Jul 20, 2026
metalgearsloth
left a comment
metalgearsloth
left a comment
Contributor
There was a problem hiding this comment.
Needs test coverage.
Member
Author
|
I'll address the review when I'm not eepy tomorrow. |
Comment on lines
+44
to
+45
| { | ||
| var sawmill = dependencies.Resolve<ILogManager>().GetSawmill("szr"); |
Contributor
There was a problem hiding this comment.
Use a dependency for this as a field since delta's pr.
Contributor
SortedListSerializer? OrderedListSerializer? Maybe want to avoid allusions to C#'s SortedList. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title.
Basically a generic version of the DamageThresholdSerializer I wrote for space-wizards/space-station-14#44644
I need the one in content merged ASAP cause we're running a bit too close to release, but I figured I could make this for engine because it's useful for ending a lot of the YAML rot that we have.
This benefit of this serializer is that you can have a bunch of list inheritance in YAML and have the serializer organize them for you, as well as combine objects in list entries the same was it does with a dictionary, without having to use a dictionary and with minimal boilerplate.
I made this while super fucking tired so the names suck and there's probably some performance hole I missed but otherwise I think it'll be useful to help with some YAML rot out there. Also basically requires [AlwaysPushInheritance] on the DataField or you're trolling.