Skip to content

Commit 01c0b3c

Browse files
committed
validation: approve task 145 runtime live e2e gate
1 parent f906472 commit 01c0b3c

1 file changed

Lines changed: 25 additions & 0 deletions

File tree

docs/plans/runtime-live-e2e-pr-trigger-and-environment-gate.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,28 @@ The summary output should continue to show:
8787
### Summary
8888

8989
Implemented the PR-native live E2E workflow shape with `CI-E2E` approval gating while keeping manual dispatch available for reruns. The workflow now carries event-specific provenance, the operator docs explain the approval flow, and the offline test coverage matches the new wiring.
90+
91+
## Stage Report: validation
92+
93+
**Validator:** Claude (ensign worker)
94+
95+
**Verification performed:**
96+
97+
1. **Workflow inspection:** Confirmed `.github/workflows/runtime-live-e2e.yml` includes both `pull_request` and `workflow_dispatch`, that `claude-live` and `codex-live` both declare `environment: CI-E2E`, and that the provenance step branches on `github.event_name` to resolve the PR number from `github.event.pull_request.number` or `inputs.pr_number` as appropriate.
98+
2. **Offline workflow test:** `unset CLAUDECODE && uv run tests/test_runtime_live_e2e_workflow.py` -> exit `0`.
99+
3. **Diff hygiene:** `git diff --check` -> exit `0`.
100+
4. **Docs inspection:** `tests/README.md` explains the PR-native flow: PR opens, runtime jobs appear, GitHub blocks them pending `CI-E2E` review, and an approved reviewer releases the jobs.
101+
102+
**Acceptance criteria verdicts:**
103+
104+
- **AC1:** PASS - both trigger paths are wired in the workflow file.
105+
- **AC2:** PASS - both runtime jobs reference `environment: CI-E2E`.
106+
- **AC3:** PASS - provenance/preflight logic resolves the correct PR number for both event shapes.
107+
- **AC4:** PASS - the operator docs describe the PR -> pending review -> release flow.
108+
- **AC5:** PASS - static workflow checks cover the trigger, environment, provenance, and docs wiring.
109+
110+
**Residual risk:**
111+
112+
- The live GitHub behavior itself was not exercised from this terminal. This validation proves the workflow structure, docs, and offline checks; the actual PR-native pending state and environment approval gate still need a live PR run to observe end-to-end.
113+
114+
**Recommendation: PASSED**

0 commit comments

Comments
 (0)