Cap FO-built dispatch checklists at ≤ 3 linchpin items#126
Merged
Conversation
Add a paragraph under step 2 of the Dispatch section in first-officer-shared-core.md framing checklist items as linchpins (at most 3, upper bound not target) and excluding boilerplate (read entity body, commit before signaling, write stage report) that is already covered by structural conventions. Add test_first_officer_shared_core_caps_checklist_at_three_linchpin_items to tests/test_agent_content.py asserting the cap, the linchpin framing, the upper-bound clarification, and the boilerplate exclusion. make test-static: 440 passed (baseline 439 + 1 new).
Team-lead amendment during implementation: lead the new paragraph with "per-dispatch, stage-level" framing and note the distinction from entity-level acceptance criteria, so the forthcoming #193 (entity-level ACs) does not have to re-negotiate terminology. Extend the static test to grep for per-dispatch / stage-level alongside the existing linchpin + cap + boilerplate assertions. make test-static: 440 passed (unchanged count).
clkao
added a commit
that referenced
this pull request
Apr 18, 2026
clkao
added a commit
that referenced
this pull request
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cap FO-built dispatch checklists at ≤ 3 linchpin items. Prose-only change to
skills/first-officer/references/first-officer-shared-core.md+ a static grep-assertion guard.What changed
first-officer-shared-core.mdframing checklist items as per-dispatch, stage-level linchpins — at most 3, upper bound not target, boilerplate (read entity, commit, write stage report) excludedtest_first_officer_shared_core_caps_checklist_at_three_linchpin_itemsintests/test_agent_content.pygrep-asserting the key phrases so the prose can't silently driftEvidence
linchpin,at most 3,upper bound, not a target,per-dispatch/stage-level, at least one excluded-boilerplate phrase,MUST NOT appear in the checklistReview guidance
Implementation dispatches this session drifted 8-14 items, enumerating mechanical steps and diluting the load-bearing signals. This rule is FO discipline — no mechanism enforcement at
claude-team build, no workflow README frontmatter override. Forward-compatible with #193 (separate AC-level entity) which will distinguish entity-level acceptance criteria from stage-level checklists using the formal vocabulary seeded here.#192