Skip to content

dispatch build — warn + document --team-name on claude (auto-team is default; legacy shape is silent)#446

Merged
clkao merged 1 commit into
mainfrom
spacedock-ensign/dispatch-build-team-name-advisory
Jun 30, 2026
Merged

dispatch build — warn + document --team-name on claude (auto-team is default; legacy shape is silent)#446
clkao merged 1 commit into
mainfrom
spacedock-ensign/dispatch-build-team-name-advisory

Conversation

@clkao

@clkao clkao commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Warn when --team-name silently selects the legacy dispatch shape on host=claude, and surface the shape-selecting flags in dispatch build --help.

What changed

  • Emit a stderr advisory when --team-name is passed on host=claude (success path; the dispatch envelope is untouched).
  • Document --host, --team-name, and --bare-mode in dispatch build --help.
  • Add a two-arm advisory test and a --help golden; the legacy-envelope shape stays frozen.

Evidence

  • All 3 ACs live-verified against a binary built from this branch (advisory present/absent two-arm, --help lists the flags, envelope byte-unchanged); no existing assertion weakened.
  • go test ./internal/dispatch/ ./internal/claudeteam/ — all passed.

0qt

…ild --help

dispatch build is Claude-team-mode-aware: omitting --team-name on host=claude
yields the auto-team shape, while passing it selects the legacy TeamCreate-
registry shape. That opt-in was invisible (undocumented in --help) and silent
(no warning), so a stray --team-name could emit the legacy envelope unnoticed.

Add claudeteam.LegacyTeamNameAdvisory, fired from runBuildFields on
!bareMode && host=="claude" && teamName!="" just before the envelope emit —
after every error guard, so it warns only when the legacy envelope is actually
emitted; an error build (no envelope) stays advisory-free. Stderr-only; the
dispatch envelope is untouched. Document --host/--team-name/--bare-mode in
printBuildUsage with wording aligned to the advisory.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@clkao
clkao force-pushed the spacedock-ensign/dispatch-build-team-name-advisory branch from d833cd5 to 1c0807d Compare June 30, 2026 19:44
@clkao
clkao merged commit ef53f07 into main Jun 30, 2026
4 of 8 checks passed
@clkao
clkao deleted the spacedock-ensign/dispatch-build-team-name-advisory branch June 30, 2026 19:45
clkao added a commit that referenced this pull request Jul 2, 2026
…ation (#462)

The sonnet lane's speculative repo-root sniff cd's outside the fixture as a
harmless version probe before settling on its (correct) launch cwd; the
detector flagged ANY escaping cd as a wander, false-reding both PR #446 runs
even though each finished the scenario correctly. A bare cd now reds only when
the same command also carries a workflow-operative token (--workflow-dir,
--boot, --discover, status --read, state commit, new, README/entity path);
standalone --workflow-dir/README-read signatures are unaffected. Also rewords
the failure text off the disproved CI-env-leak cause.

Checks in the two archived PR #446 sonnet streams as replay testdata (both
return nil post-fix; reproduced the exact CI failures pre-fix) alongside the
four corroborated-wander fixtures (still 4/4 red).

Co-authored-by: Spike Test <spike@example.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant