Skip to content

codex --plugin-dir advisory: drop the internal branch name from shipped CLI output#458

Merged
clkao merged 1 commit into
mainfrom
spacedock-ensign/codex-plugin-dir-advisory-internal-ref
Jul 2, 2026
Merged

codex --plugin-dir advisory: drop the internal branch name from shipped CLI output#458
clkao merged 1 commit into
mainfrom
spacedock-ensign/codex-plugin-dir-advisory-internal-ref

Conversation

@clkao

@clkao clkao commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Drop the internal branch name from the codex --plugin-dir version-masquerade advisory so shipped CLI output carries no identifier an end user cannot act on.

What changed

  • Reword the advisory in installCodexLocalPluginDir to end at "not necessarily its current HEAD" (no next-post-release-preversion-bump).
  • Clean the companion docstring the same way ("the full stamping fix is deferred").
  • Add a test guard asserting the shipped advisory contains no internal branch token, plus a surviving-meaning assertion.

Evidence

  • internal/cli: all tests pass; go build ./... green.
  • AC-1 is baseline-fails-on-main (the token emits today), so the guard can move the wrong way; the presence/absence pair stays green.

ac

… advisory

The --plugin-dir install advisory ended with "— see
next-post-release-preversion-bump", leaking an internal roadmap/branch
identifier into shipped stderr that an end user cannot act on. End the
sentence after "not necessarily its current HEAD"; the advisory is purely
informational and no public docs page describes it, so no pointer is added.
Fold in the twin internal-branch reference in the function docstring
("the full stamping fix lives in ..." -> "is deferred").

Guard the shipped bytes in TestCodexPluginDirAdvisoryPresenceAndAbsence:
assert stderr carries no "next-post-release-preversion-bump" token and
still carries the meaning-bearing "not necessarily its current HEAD" clause;
the present-on-install / absent-on-plain-launch pair stays green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@clkao
clkao merged commit 3841618 into main Jul 2, 2026
4 of 8 checks passed
@clkao
clkao deleted the spacedock-ensign/codex-plugin-dir-advisory-internal-ref branch July 2, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant