e2e-gate --status success filter hides re-run-to-green Runtime Live E2E runs from the release gate#460
Merged
Conversation
added 2 commits
July 2, 2026 10:36
At the v0.23.0 cut, gh run list --status success returned [] for a run re-run to green minutes earlier (conclusion success, attempt 2), while the same query without --status already saw the success -- the filter lags conclusion right after a re-run, blocking a genuinely green cut. The parked-run defense the flag was meant to provide already lives in EvaluateE2EGate's predicate (empty conclusion never matches), so the flag was redundant and only cost re-run-to-green cuts. T1 drives the real ghRunListForCommit against a fake gh shim pinning the gate-time observation (RED under --status, GREEN once dropped). T2 confirms the parked-run defense survives the flag's removal.
…matrix binding Cycle-1 audit finding: workflowName is not among ghRunListForCommit's fetched --json fields, so the --workflow "Runtime Live E2E" argv token is the ONLY thing binding the release gate to the live matrix. Dropping it left the whole suite green -- any green run on the release commit (e.g. ordinary push CI) would then satisfy the gate. The gh shim now returns [] unless argv carries that exact --workflow "Runtime Live E2E" pair, so the token's removal fails the gate closed in the test. Verified locally: removing the token from ghRunListForCommit flips TestE2EGateCommandPassesOnRerunToGreenLiveRun RED (exit 1, "no conclusion:success..."); reverting restores GREEN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Runtime Live E2E run re-run to green was invisible to the release e2e-gate, blocking the v0.23.0 cut on a genuinely green matrix.
What changed
--status successfrom the e2e-gate'sgh run listquery--workflow "Runtime Live E2E"as the live-matrix bindingEvidence
go test ./...15/15 packages passed;-racegreen on both touched packages--workflowhole closed in cycle 1q3