Merge pull request #567 from spacedriveapp/codex/land-memory-observation-p2

feat(memory): expand working-memory event semantics

Author: jamiepine

docs/design-docs/working-memory-implementation-plan.md

@@ -158,6 +158,12 @@ pub enum WorkingMemoryEventType {
     CronExecuted,
     MemorySaved,
     Decision,
+    UserCorrection,
+    DecisionRevised,
+    DeadlineSet,
+    BlockedOn,
+    Constraint,
+    Outcome,
     Error,
     TaskUpdate,
     AgentMessage,
@@ -861,7 +867,8 @@ Update `prompts/en/memory_persistence.md.j2` to add:
 In addition to saving graph memories, identify key decisions and important events
 from the conversation. For each, include it in the `events` field of
 memory_persistence_complete. Events should be one-line summaries with a type
-("decision", "error", "system") and importance score (0.0-1.0).
+("decision", "user_correction", "decision_revised", "deadline_set", "blocked_on",
+"constraint", "outcome", "error", "system") and importance score (0.0-1.0).
 ```
 
 Update `src/tools/memory_persistence_complete.rs`:

docs/design-docs/working-memory.md

@@ -75,6 +75,18 @@ pub enum WorkingMemoryEventType {
     MemorySaved,
     /// A decision was made (extracted from conversation)
     Decision,
+    /// The user corrected a prior assumption, instruction, or framing
+    UserCorrection,
+    /// A prior decision changed after feedback or new information
+    DecisionRevised,
+    /// A concrete due date, deadline, or scheduled milestone was set
+    DeadlineSet,
+    /// Progress is waiting on approval, missing input, or an external dependency
+    BlockedOn,
+    /// A hard requirement, limitation, or non-negotiable boundary was stated
+    Constraint,
+    /// A task, branch, or delegated step reached a clear terminal result
+    Outcome,
     /// An error or failure occurred
     Error,
     /// A task was created or updated
@@ -455,19 +467,19 @@ The periodic memory persistence branch currently runs every 50 user messages. Re
 
 ### Persistence Branch Dual Output
 
-The memory persistence branch gains a second responsibility: in addition to saving graph memories, it emits `Decision` and `MemorySaved` events into the working memory log. This connects the two systems:
+The memory persistence branch gains a second responsibility: in addition to saving graph memories, it emits typed conversational events into the working memory log. This connects the two systems:
 
 ```
 Persistence branch runs:
   1. Recalls existing graph memories (avoid duplicates)
   2. Reads conversation history since last run
   3. Saves new graph memories via memory_save (as today)
   4. Identifies key decisions and events
-  5. Emits working memory events for each decision identified
+  5. Emits working memory events for each important event identified
   6. Calls memory_persistence_complete
 ```
 
-Step 5 is new. The persistence branch prompt is updated to instruct it to identify decisions explicitly. The `memory_persistence_complete` tool gains an optional `events` field:
+Step 5 is new. The persistence branch prompt is updated to identify durable temporal events explicitly: decisions, user corrections, revised decisions, concrete deadlines, blockers, constraints, terminal outcomes, errors, and system events. The `memory_persistence_complete` tool gains an optional `events` field:
 
 ```rust
 pub struct MemoryPersistenceCompleteArgs {
@@ -477,7 +489,7 @@ pub struct MemoryPersistenceCompleteArgs {
 }
 
 pub struct WorkingMemoryEventInput {
-    pub event_type: String,       // "decision", "error", etc.
+    pub event_type: String,       // "decision", "blocked_on", "outcome", etc.
     pub summary: String,
     pub importance: Option<f32>,
 }
@@ -490,14 +502,18 @@ The majority of working memory events are captured programmatically, with zero L
 | Event            | Emitter                                      | How                                                                  |
 | ---------------- | -------------------------------------------- | -------------------------------------------------------------------- |
 | Worker spawned   | `spawn_worker` tool handler                  | After successful spawn, write event with task description as summary |
-| Worker completed | Worker state machine terminal transition     | Write event with worker result summary (truncated to 200 chars)      |
-| Branch completed | Branch return path in channel                | Write event with branch conclusion (truncated to 200 chars)          |
+| Worker completed | Worker state machine terminal transition     | Write typed result, blocker, constraint, or deadline event when the summary uses a recognized prefix; otherwise write `WorkerCompleted` |
+| Branch completed | Branch return path in channel                | Write typed result, blocker, constraint, or deadline event when the summary uses a recognized prefix; otherwise write `BranchCompleted` |
 | Cron executed    | Cron scheduler after job completes           | Write event with cron name + outcome                                 |
 | Memory saved     | `memory_save` tool handler                   | Write event with memory type + content preview                       |
-| Task updated     | Task tool handlers                           | Write event with task title + new status                             |
+| Task updated     | Task tool handlers                           | Write `Outcome` when a task transitions to `done`; otherwise write `TaskUpdate` with task status |
+| Duplicate worker | `spawn_worker` duplicate guard               | Write `BlockedOn` with the active worker ID and duplicate task preview |
+| Agent delegation | `send_agent_message` tool handler            | Write `Outcome` when delegation creates the cross-agent task          |
 | Error            | SpacebotHook on tool failure, worker failure | Write event with error description                                   |
 | System           | Startup, config change, maintenance          | Write event with description                                         |
 
+Branch and worker summaries may opt into richer event types with these prefixes: `outcome:`, `blocked_on:` or `blocked on:`, `constraint:`, and `deadline_set:` or `deadline:`. The prefix is stripped before rendering the event summary.
+
 Each emitter calls `working_memory_store.record_event()` as a fire-and-forget `tokio::spawn`. The message processing pipeline never waits on event recording.
 
 ```rust

prompts/en/memory_persistence.md.j2

@@ -32,13 +32,17 @@ This is an automatic process triggered periodically during conversation. You are
      - `"decision"` for commitments or choices made
      - `"user_correction"` when the user corrects a prior assumption, instruction, or framing
      - `"decision_revised"` when a prior choice changes after feedback or new information
+     - `"deadline_set"` when the conversation establishes a concrete due date, deadline, or scheduled milestone
+     - `"blocked_on"` when progress is waiting on an approval, dependency, missing input, or external action
+     - `"constraint"` when the user or system states a hard requirement, limitation, or non-negotiable boundary
+     - `"outcome"` when a task, branch, or delegated step reaches a clear terminal result worth retaining in temporal memory
      - `"error"` for failures or problems
      - `"system"` for other notable events
    - `summary`: one-line description of what happened
    - Normalize relative time references to absolute dates/times with timezone
      (for example `2026-03-31T14:20:00-04:00`) so downstream memory checks are
      stable across sessions.
-   - `importance`: 0.0-1.0 score (`decision`, `user_correction`, and `decision_revised` are typically 0.6-0.8)
+   - `importance`: 0.0-1.0 score (`decision`, `user_correction`, `decision_revised`, `blocked_on`, and `outcome` are typically 0.6-0.8)
    - Events feed the agent's temporal working memory — they help the agent remember *what happened today*, not just facts.
 
 5. **Finish with the terminal tool.** You must call `memory_persistence_complete` before finishing: