Skip to content

Revert "cuda: add v13.1.2, v13.2.0, v13.2.1 and v13.3.0"#5088

Closed
sethrj wants to merge 1 commit into
developfrom
revert-4897-updates/cuda
Closed

Revert "cuda: add v13.1.2, v13.2.0, v13.2.1 and v13.3.0"#5088
sethrj wants to merge 1 commit into
developfrom
revert-4897-updates/cuda

Conversation

@sethrj
Copy link
Copy Markdown
Contributor

@sethrj sethrj commented Jun 4, 2026

Reverts #4897 : downstream packages including strumpack seem to fail with it; they weren't tested on gitlab CI due to an error introduced by #4615 and fixed in #5046.

Draft to test whether the pipeline passes with the reversion.

@rbberger
Copy link
Copy Markdown
Member

rbberger commented Jun 4, 2026

@sethrj instead of reverting, you should document which ones are failing for you and add conflicts.

@sethrj
Copy link
Copy Markdown
Contributor Author

sethrj commented Jun 4, 2026

This unfortunately is due to a lapse in the CI system; it's the responsibility of each PR to make sure that new capabilities don't break other code. I'm mostly trying to verify that the CI works after this; a couple of software packages have been broken on develop since #4897 .

https://gitlab.spack.io/spack/spack-packages/-/pipelines/1623929

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jun 4, 2026

@sethrj Use the don't merge yet label and make this a normal PR. Pipelines don't run on draft PRs 😬

@balay
Copy link
Copy Markdown
Contributor

balay commented Jun 4, 2026

https://gitlab.spack.io/spack/spack-packages/-/jobs/22451976

/tmp/root/spack-stage/spack-stage-petsc-3.25.1-lxmyy25uscljmm3jlejoth6zcia3lveg/spack-src/src/mat/impls/diagonal/cupm/cuda/../matdiagonalcupm.hpp(43): error: namespace "thrust" has no member "tuple"
    using argument_type = thrust::tuple<PetscScalar, PetscScalar, PetscScalar>;

FWIW cuda@13.3 build issue is fixed in petsc@3.25.2 - that got similarly merged to develop via

#5053

@balay
Copy link
Copy Markdown
Contributor

balay commented Jun 4, 2026

@sethrj Use the don't merge yet label and make this a normal PR. Pipelines don't run on draft PRs 😬

The label can be easily ignored [I've had that issue once].

Would be nice if the restriction on draft PRs can be removed [or be able to add in CI via a lablel - or other mechanisms]

@sethrj sethrj marked this pull request as ready for review June 4, 2026 16:23
@balay
Copy link
Copy Markdown
Contributor

balay commented Jun 5, 2026

Is it worth checking if just reverting cuda-13.3 (or making cuda-13.2.1 the default) would work - without a full revert?

@balay
Copy link
Copy Markdown
Contributor

balay commented Jun 5, 2026

And I see tau, strumpack have PRs related to cuda-13.2+ merged in (along with petsc).

Likely outstanding pkgs [from the above pipeline failure]:

  • visit
  • omega-h

@balay
Copy link
Copy Markdown
Contributor

balay commented Jun 5, 2026

Copy link
Copy Markdown
Member

@rbberger rbberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert seems overkill at this point.

@sethrj sethrj closed this Jun 6, 2026
@sethrj sethrj deleted the revert-4897-updates/cuda branch June 6, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants