[PACKAGE] Add libxs#5116
Open
mtaillefumier wants to merge 3 commits into
Open
Conversation
- Added libxs dependency - Updated cp2k
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/cp2k/package.py
repos/spack_repo/builtin/packages/libxs/package.py
�[1;34m==> �[0mrunning ruff format
2 files reformatted
�[1;34m==> �[0mrunning ruff check
�[1m�[91mF841 �[0m�[1mLocal variable `spec` is assigned to but never used�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/libxs/package.py:42:9
�[1m�[94m|�[0m
�[1m�[94m41 |�[0m def cmake_args(self):
�[1m�[94m42 |�[0m spec = self.spec
�[1m�[94m|�[0m �[1m�[91m^^^^�[0m
�[1m�[94m43 |�[0m args = [
�[1m�[94m44 |�[0m self.define_from_variant("LIBXS_FORTRAN", "fortran"),
�[1m�[94m|�[0m
�[1m�[96mhelp�[0m: �[1mRemove assignment to unused variable `spec`�[0m
Found 2 errors (1 fixed, 1 remaining).
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).
I've updated the branch with style fixes. |
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/cp2k/package.py
repos/spack_repo/builtin/packages/libxs/package.py
�[1;34m==> �[0mrunning ruff format
2 files left unchanged
�[1;34m==> �[0mrunning ruff check
All checks passed!
�[1;34m==> �[0mstyle checks passed
I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the libxs package.py written by @mkrack and update the cp2k package.py file accordingly