1.0/last updates tuesday sections#478
Merged
Merged
Conversation
Signed-off-by: Gregory Becker <becker33@llnl.gov>
Signed-off-by: Gregory Becker <becker33@llnl.gov>
Member
Signed-off-by: Gregory Becker <becker33@llnl.gov>
alalazo
approved these changes
Aug 5, 2025
Member
There was a problem hiding this comment.
(nitpick, feel free to close without modifications if it seems pedantic) Changes to this file looks good. A minor point is in this wording:
Note the identifier clang_gfortran is not itself a spec (you don’t version it). You reference it in other specs.
I'd rather say something like:
Toolchains are not specs, so they don't have versions or variants, but are referenced only by their names, in this case by `clang_gfortran`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Final minor fixes from testing on both potential AMIs