Packaging: v1.0 Corrections and Additional Updates#484
Merged
Conversation
Signed-off-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Signed-off-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Signed-off-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Signed-off-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
…e (at CLI) issue Signed-off-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
…chive URL Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
ae5f7fd to
e46435e
Compare
Signed-off-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
…hen script runs Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
69624ba to
7ff0e72
Compare
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
f0da501 to
dbd68b8
Compare
Signed-off-by: tldahlgren <dahlgren1@llnl.gov>
Contributor
Author
|
Since there are important corrections in this PR and another tutorial coming up quickly, I would rather not let this PR languish. The assumption is the next person giving this tutorial will make updates as needed anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes additional
v1.0corrections and updates, to include:stackstartdefaulttype frominttostrto stop the warnings;leakedto thempileaksdescription to match what is currently in the source repository's description;packaging.sh) fromrepostomy_pkgsto be less confusing w.r.t. repository-related commands and ensure consistency with presentation text;packaging.shto display$HOMEwhere possible (to make copy-and-paste during tutorials easier);tutorial-mpileaksand provided a link to the ONLY package that actually calls theautogen.shscript;uncomment/update some of.packaging.sh's examples