Skip to content

fix: replace unused pydantic import with importlib.util.find_spec #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sansyrox merged 2 commits into from
Mar 28, 2026
Merged

fix: replace unused pydantic import with importlib.util.find_spec #1343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
404166f
fix: replace unused pydantic import with importlib.util.find_spec
sansyrox Mar 22, 2026
98c14c7
fix: sort imports in openapi.py to satisfy isort
sansyrox Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions integration_tests/test_pydantic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
import importlib.util

import pytest
import requests

from integration_tests.helpers.http_methods_helpers import json_post

BASE_URL = "http://127.0.0.1:8080"

try:
import pydantic

_HAS_PYDANTIC = True
except ImportError:
_HAS_PYDANTIC = False
_HAS_PYDANTIC = importlib.util.find_spec("pydantic") is not None

pytestmark = pytest.mark.skipif(not _HAS_PYDANTIC, reason="pydantic not installed")

Expand Down
2 changes: 1 addition & 1 deletion robyn/openapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
from pathlib import Path
from typing import Any, Callable, Dict, List, Optional, Tuple, TypedDict, is_typeddict

from robyn.pydantic_support import get_pydantic_openapi_schema, is_pydantic_model
from robyn.responses import html
from robyn.robyn import QueryParams, Response
from robyn.pydantic_support import get_pydantic_openapi_schema, is_pydantic_model
from robyn.types import Body, JsonBody

_logger = logging.getLogger(__name__)
Expand Down
Loading