upgrade readme (#1)#13
Open
wuuuduu wants to merge 2 commits into
Open
Conversation
Co-authored-by: wuuuduu <github@kornel.dev>
szymborski
requested changes
Sep 20, 2022
szymborski
reviewed
Sep 20, 2022
| ) | ||
| def get_absolute_url(self): | ||
| return reverse('order-detail', kwargs={"pk": self.pk}) | ||
| return f"{settings.FRONTEND_URL}/order/{self.pk}" |
szymborski
requested changes
Sep 20, 2022
| .. code-block:: python | ||
|
|
||
| FRONTEND_URL = "https://mydomain.tld" | ||
| assert not FRONTEND_URL.endswith("/") |
There was a problem hiding this comment.
I wonder if that is safe to apply on all projects. Maybe we should just use urljoin and don't care about slash?
Co-authored-by: wuuuduu <git@kornel.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: wuuuduu github@kornel.dev