getAllowExceptInCalls loop to check all entries before allowing

Author: Copilot

src/Allowed/Allowed.php

@@ -64,10 +64,13 @@ public function isAllowed(?Node $node, Scope $scope, ?array $args, Disallowed $d
 				return !$hasParams || $this->hasAllowedParamsInAllowed($scope, $args, $disallowed);
 			}
 		}
-		foreach ($disallowed->getAllowExceptInCalls() as $call) {
-			if (!$this->callMatches($scope, $call)) {
-				return true;
+		if ($disallowed->getAllowExceptInCalls()) {
+			foreach ($disallowed->getAllowExceptInCalls() as $call) {
+				if ($this->callMatches($scope, $call)) {
+					return false;
+				}
 			}
+			return true;
 		}
 		foreach ($disallowed->getAllowIn() as $allowedPath) {
 			if ($this->allowedPath->matches($scope, $allowedPath)) {

tests/Calls/FunctionCallsAllowExceptInMultipleMethodsTest.php

@@ -0,0 +1,67 @@
+<?php
+declare(strict_types = 1);
+
+namespace Spaze\PHPStan\Rules\Disallowed\Calls;
+
+use PHPStan\Rules\Rule;
+use PHPStan\ShouldNotHappenException;
+use PHPStan\Testing\RuleTestCase;
+use Spaze\PHPStan\Rules\Disallowed\DisallowedCallFactory;
+use Spaze\PHPStan\Rules\Disallowed\RuleErrors\DisallowedCallableParameterRuleErrors;
+use Spaze\PHPStan\Rules\Disallowed\RuleErrors\DisallowedFunctionRuleErrors;
+
+/**
+ * @extends RuleTestCase<FunctionCalls>
+ */
+class FunctionCallsAllowExceptInMultipleMethodsTest extends RuleTestCase
+{
+
+	/**
+	 * @throws ShouldNotHappenException
+	 */
+	protected function getRule(): Rule
+	{
+		$container = self::getContainer();
+		return new FunctionCalls(
+			$container->getByType(DisallowedFunctionRuleErrors::class),
+			$container->getByType(DisallowedCallableParameterRuleErrors::class),
+			$container->getByType(DisallowedCallFactory::class),
+			[
+				[
+					'function' => 'crc32()',
+					'allowExceptInMethods' => [
+						'\\Fiction\\Pulp\\RoyaleMultiple::methodA()',
+						'\\Fiction\\Pulp\\RoyaleMultiple::methodB()',
+					],
+				],
+			]
+		);
+	}
+
+
+	public function testRule(): void
+	{
+		// Based on the configuration above, in this file:
+		$this->analyse([__DIR__ . '/../src/RoyaleMultiple.php'], [
+			[
+				// expect this error message:
+				'Calling crc32() is forbidden.',
+				// on this line:
+				11,
+			],
+			[
+				'Calling crc32() is forbidden.',
+				17,
+			],
+		]);
+	}
+
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../extension.neon',
+		];
+	}
+
+}

tests/src/RoyaleMultiple.php

@@ -0,0 +1,26 @@
+<?php
+declare(strict_types = 1);
+
+namespace Fiction\Pulp;
+
+class RoyaleMultiple
+{
+
+	public function methodA(): void
+	{
+		$foo = crc32('a');
+	}
+
+
+	public function methodB(): void
+	{
+		$foo = crc32('b');
+	}
+
+
+	public function methodC(): void
+	{
+		$foo = crc32('c');
+	}
+
+}