Enable running the e2e tests manually#398
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the e2e GitHub Actions workflow so it can be run via workflow_dispatch by falling back to github.ref_name when github.head_ref is empty, preventing an invalid composer require branch alias during manual runs.
Changes:
- Use
github.head_ref || github.ref_namewhen building thedev-<branch>alias forcomposer requirein the e2e workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spaze
force-pushed
the
spaze/e2e-workflow_dispatch
branch
from
029e481 to
5f98b98
Compare
`github.head_ref` is only set on `pull_request` events; `workflow_dispatch` leaves it empty, whcih caused the `composer require` step to request an invalid "dev-" branch alias and fail.
spaze
force-pushed
the
spaze/e2e-workflow_dispatch
branch
from
5f98b98 to
fdcda0a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions E2E workflow so it can be run via workflow_dispatch (manual runs) without failing due to an empty github.head_ref, by falling back to github.ref_name and guarding against non-branch dispatch refs.
Changes:
- Add a job-level
HEAD_REFenv var using${{ github.head_ref || github.ref_name }}. - Fail early on
workflow_dispatchwhen the selected ref is not a branch. - Use
HEAD_REFin the “composer require” step (including the step name) to avoid producing an invaliddev-constraint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
github.ref_nameas fallback forgithub.head_refin e2e workflow:github.head_refis only set onpull_requestevents;workflow_dispatchleaves it empty, whcih caused thecomposer requirestep to request an invalid "dev-" branch alias and fail.