Commit 6931219
committed
use string.Builder in sankey exporter
Why this is better:
Performance: strings.Builder minimizes memory allocations compared to printing line-by-line.
Atomicity: fmt.Print calls are thread-safe, but if we do 10 Println calls in a loop, another goroutine could print something in between them. By building one large string and printing it once, the entire Sankey block stays together in logs.1 parent 0304b8b commit 6931219
1 file changed
Lines changed: 11 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
52 | 57 | | |
53 | | - | |
54 | 58 | | |
55 | | - | |
56 | 59 | | |
57 | 60 | | |
58 | 61 | | |
| |||
61 | 64 | | |
62 | 65 | | |
63 | 66 | | |
64 | | - | |
65 | 67 | | |
66 | 68 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 69 | + | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | | - | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
| 77 | + | |
| 78 | + | |
84 | 79 | | |
0 commit comments