Allow underscores in git download location

Fixes #33

Author: goneall

src/main/java/org/spdx/library/model/v2/SpdxConstantsCompatV2.java

@@ -365,7 +365,7 @@ public class SpdxConstantsCompatV2 {
 	// Download Location Format
 	private static final String SUPPORTED_DOWNLOAD_REPOS = "(git|hg|svn|bzr)";
 	private static final String URL_PATTERN = "([^:/?#]+://)?[a-z0-9]+([\\-\\.]{1}[a-z0-9]+){0,100}\\.[a-z]{2,5}(:[0-9]{1,5})?(\\/.*)?";
-	private static final String GIT_PATTERN = "(git\\+git@[a-zA-Z0-9\\.\\-]+:[a-zA-Z0-9/\\\\.@\\-]+)";
+	private static final String GIT_PATTERN = "(git\\+git@[a-zA-Z0-9\\.\\-]+:[a-zA-Z0-9/\\\\.@\\-_]+)";
 	private static final String BAZAAR_PATTERN = "(bzr\\+lp:[a-zA-Z0-9\\.\\-]+)";
 	public static final Pattern DOWNLOAD_LOCATION_PATTERN = Pattern.compile("^(NONE|NOASSERTION|(("+SUPPORTED_DOWNLOAD_REPOS+"\\+)?"+URL_PATTERN+")|"+GIT_PATTERN+"|"+BAZAAR_PATTERN+")$", Pattern.CASE_INSENSITIVE);
 

src/test/java/org/spdx/library/model/compat/v2/SpdxPackageTest.java

@@ -70,6 +70,7 @@ public class SpdxPackageTest extends TestCase {
 	static final String DESCRIPTION2 = "Description 2";
 	static final String DOWNLOAD_LOCATION1 = "git+git://git.myproject.org/MyProject";
 	static final String DOWNLOAD_LOCATION2 = "hg+https://hg.myproject.org/MyProject#src/somefile.c";
+	static final String DOWNLOAD_LOCATION3 = "git+git://git.myproject.org/MyProject_test";
 	static final String HOMEPAGE1 = "http://home.page.one/one";
 	static final String HOMEPAGE2 = "http://home.page.two/two2";
 	static final String ORIGINATOR1 = "Organization: Originator1";
@@ -608,6 +609,9 @@ public void testSetDownloadLocation() throws InvalidSPDXAnalysisException {
 		assertEquals(DOWNLOAD_LOCATION_S3, pkg.getDownloadLocation().get());
 		assertEquals(DOWNLOAD_LOCATION_S3, pkg2.getDownloadLocation().get());
 		assertTrue(pkg.verify().isEmpty());
+		pkg.setDownloadLocation(DOWNLOAD_LOCATION3);
+		assertEquals(DOWNLOAD_LOCATION3, pkg.getDownloadLocation().get());
+		assertTrue(pkg.verify().isEmpty());
 	}
 
 	/**