Skip to content

Commit 4990d5b

Browse files
committed
Revert "Add tests for defer destroy in ShaeWorkerElement (#3)"
This reverts commit 56c68dc.
1 parent 56c68dc commit 4990d5b

3 files changed

Lines changed: 5 additions & 125 deletions

File tree

TODO.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# @spearwolf/shadow-objects-monorepo
33

4-
> _Generated by [scripts/makeTODO.mjs](scripts/makeTODO.mjs) at 2025-11-27T13:51:08.921Z_
4+
> _Generated by [scripts/makeTODO.mjs](scripts/makeTODO.mjs) at 2025-11-26T11:50:56.346Z_
55
66
This file contains an overview of all TODO, FIXME or XXX comments extracted from the source files of the packages.
77

@@ -24,4 +24,5 @@ This file contains an overview of all TODO, FIXME or XXX comments extracted from
2424
### TODOs
2525
| Filename | line # | TODO |
2626
|:------|:------:|:------|
27+
| [packages/shadow-objects/src/elements/ShaeWorkerElement.ts](packages/shadow-objects/src/elements/ShaeWorkerElement.ts#L200) | 200 | @test add tests for defer destroy |
2728

packages/shadow-objects/src/elements/ShaeWorkerElement.spec.ts

Lines changed: 0 additions & 122 deletions
This file was deleted.

packages/shadow-objects/src/elements/ShaeWorkerElement.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,9 @@ export class ShaeWorkerElement extends ShaeElement {
172172
}
173173

174174
start(): Promise<ShadowEnv> {
175-
this.#shouldDestroy = false;
176-
177175
if (!this.#started) {
176+
this.#shouldDestroy = false;
177+
178178
this.shadowEnv.view ??= ComponentContext.get(this.ns);
179179

180180
if (this.shadowEnv.envProxy == null) {
@@ -197,6 +197,7 @@ export class ShaeWorkerElement extends ShaeElement {
197197
this.shadowEnv.destroy();
198198
}
199199

200+
// TODO(test) add tests for defer destroy
200201
#deferDestroy() {
201202
if (!this.#shouldDestroy) {
202203
this.#shouldDestroy = true;

0 commit comments

Comments
 (0)