Skip to content

Commit 51dfc8f

Browse files
Copilotspearwolf
andauthored
Add tests for ShadowObjectParams API in Kernel.ts (#2)
* Initial plan * Add comprehensive tests for ShadowObjectParams API in Kernel.ts and remove associated TODOs Co-authored-by: spearwolf <12805+spearwolf@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: spearwolf <12805+spearwolf@users.noreply.github.com>
1 parent fe7c1bc commit 51dfc8f

5 files changed

Lines changed: 754 additions & 45 deletions

File tree

TODO.md

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# @spearwolf/shadow-objects-monorepo
33

4-
> _Generated by [scripts/makeTODO.mjs](scripts/makeTODO.mjs) at 2025-11-26T11:25:15.158Z_
4+
> _Generated by [scripts/makeTODO.mjs](scripts/makeTODO.mjs) at 2025-11-26T11:50:56.346Z_
55
66
This file contains an overview of all TODO, FIXME or XXX comments extracted from the source files of the packages.
77

@@ -25,23 +25,4 @@ This file contains an overview of all TODO, FIXME or XXX comments extracted from
2525
| Filename | line # | TODO |
2626
|:------|:------:|:------|
2727
| [packages/shadow-objects/src/elements/ShaeWorkerElement.ts](packages/shadow-objects/src/elements/ShaeWorkerElement.ts#L200) | 200 | @test add tests for defer destroy |
28-
| [packages/shadow-objects/src/in-the-dark/Entity.ts](packages/shadow-objects/src/in-the-dark/Entity.ts#L311) | 311 | @test write tests for useContext() |
29-
| [packages/shadow-objects/src/in-the-dark/Entity.ts](packages/shadow-objects/src/in-the-dark/Entity.ts#L317) | 317 | @test write tests for useParentContext() |
30-
| [packages/shadow-objects/src/in-the-dark/Entity.ts](packages/shadow-objects/src/in-the-dark/Entity.ts#L323) | 323 | @test write tests for provideContext() |
31-
| [packages/shadow-objects/src/in-the-dark/events.ts](packages/shadow-objects/src/in-the-dark/events.ts#L7) | 7 | @test test if OnCreate is called when an entity token is changed |
32-
| [packages/shadow-objects/src/in-the-dark/events.ts](packages/shadow-objects/src/in-the-dark/events.ts#L25) | 25 | @test test if OnDestroy is called when an entity is destroyed |
33-
| [packages/shadow-objects/src/in-the-dark/events.ts](packages/shadow-objects/src/in-the-dark/events.ts#L26) | 26 | @test test if OnDestroy is called when a shadow-object is removed from an entity (token-change) |
34-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L363) | 363 | create tests |
35-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L386) | 386 | create tests |
36-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L413) | 413 | create tests |
37-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L425) | 425 | create tests |
38-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L437) | 437 | create tests |
39-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L440) | 440 | create tests |
40-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L451) | 451 | create tests |
41-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L475) | 475 | create tests |
42-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L482) | 482 | create tests |
43-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L491) | 491 | create tests |
44-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L500) | 500 | create tests |
45-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L508) | 508 | create tests |
46-
| [packages/shadow-objects/src/in-the-dark/Kernel.ts](packages/shadow-objects/src/in-the-dark/Kernel.ts#L516) | 516 | create tests |
4728

packages/shadow-objects/src/in-the-dark/Entity.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -308,20 +308,14 @@ export class Entity {
308308
return this.#context.has(name);
309309
}
310310

311-
// TODO(test) write tests for useContext()
312-
313311
useContext<T = unknown>(name: ContextNameType): SignalReader<T> {
314312
return this.#findOrCreateContext(name).context.get as SignalReader<T>;
315313
}
316314

317-
// TODO(test) write tests for useParentContext()
318-
319315
useParentContext<T = unknown>(name: ContextNameType): SignalReader<T> {
320316
return this.#findOrCreateContext(name).inherited.get as SignalReader<T>;
321317
}
322318

323-
// TODO(test) write tests for provideContext()
324-
325319
provideContext<T = unknown>(name: ContextNameType): Signal<T> {
326320
return this.#findOrCreateContext(name).provide as Signal<T>;
327321
}

0 commit comments

Comments
 (0)