chore: fix lint errors

Author: spearwolf

biome.json

@@ -27,7 +27,8 @@
       "!**/pnpm-lock.yaml",
       "!**/CHANGELOG.md",
       "!docs/superpowers/specs/dist-snapshot.txt",
-      "!docs/superpowers/specs/dist-package.json.snapshot"
+      "!docs/superpowers/specs/dist-package.json.snapshot",
+      "!audit.html"
     ]
   },
   "formatter": {

packages/shadow-objects-e2e/vite.config.mjs

@@ -1,6 +1,6 @@
-import {readdirSync} from 'fs';
-import {basename, dirname, resolve} from 'path';
-import {fileURLToPath} from 'url';
+import {readdirSync} from 'node:fs';
+import {basename, dirname, resolve} from 'node:path';
+import {fileURLToPath} from 'node:url';
 import {defineConfig} from 'vite';
 
 const projectRoot = dirname(fileURLToPath(import.meta.url));

packages/shadow-objects-testing/test/emit-helper/emit-helper.test.js

@@ -22,7 +22,7 @@ describe('ShadowObjectCreationAPI.emit helper', () => {
   afterEach(() => {
     ComponentContext.get().clear();
     const localEnv = document.getElementById('localEnv');
-    if (localEnv && localEnv.shadowEnv) {
+    if (localEnv?.shadowEnv) {
       localEnv.shadowEnv.destroy();
     }
   });

packages/shadow-objects/src/elements/ShaePropElement.ts

@@ -226,7 +226,7 @@ export class ShaePropElement extends HTMLElement {
 
           case 'int[]':
           case 'integer[]':
-            value = value.split(/\s+/).map((v) => parseInt(v));
+            value = value.split(/\s+/).map((v) => parseInt(v, 10));
             break;
 
           case 'hex[]':

packages/shadow-objects/src/in-the-dark/Kernel.spec.ts

@@ -334,8 +334,8 @@ describe('Kernel', () => {
         ]);
 
         expect(capturedProps).toBeDefined();
-        expect(value(capturedProps!['foo'])).toBe('valueA');
-        expect(value(capturedProps!['bar'])).toBe('valueB');
+        expect(value(capturedProps!.foo)).toBe('valueA');
+        expect(value(capturedProps!.bar)).toBe('valueB');
 
         kernel.destroy();
       });

packages/shadow-objects/src/in-the-dark/Registry.ts

@@ -23,8 +23,8 @@ const addRoutes = (set: Set<string>, routes: string[] | Set<string>) => {
 
 const addConstructors = (entry: RegistryEntry | null | undefined, constructors: Set<ShadowObjectConstructor>) => {
   if (entry != null) {
-    for (const constructor of entry.constructors) {
-      constructors.add(constructor);
+    for (const c of entry.constructors) {
+      constructors.add(c);
     }
   }
 };
@@ -40,11 +40,11 @@ export class Registry {
   readonly #routes = new Map<string, Set<string>>();
   readonly #truthyPropRoutes = new Map<string, {routes: Set<string>; token?: string}>();
 
-  define(token: string, constructor: ShadowObjectConstructor) {
+  define(token: string, constructa: ShadowObjectConstructor) {
     if (this.#registry.has(token)) {
-      appendTo(this.#registry.get(token)!.constructors, constructor);
+      appendTo(this.#registry.get(token)!.constructors, constructa);
     } else {
-      this.#registry.set(token, {token, constructors: [constructor]});
+      this.#registry.set(token, {token, constructors: [constructa]});
     }
   }
 

packages/shadow-objects/src/in-the-dark/ShadowObject.ts

@@ -29,7 +29,7 @@ export function ShadowObject(options: ShadowObjectDecoratorOptions) {
  * If you don't want to use the decorator, you can simply call this method instead.
  */
 export const shadowObjects = {
-  define(token: string, constructor: ShadowObjectConstructor, registry?: Registry) {
-    Registry.get(registry).define(token, constructor);
+  define(token: string, constructa: ShadowObjectConstructor, registry?: Registry) {
+    Registry.get(registry).define(token, constructa);
   },
 };

packages/shadow-objects/src/in-the-dark/importModule.ts

@@ -21,8 +21,8 @@ export async function importModule(
   const {registry} = kernel;
 
   if (module.define) {
-    for (const [token, constructor] of Object.entries(module.define)) {
-      registry.define(token, constructor as ShadowObjectConstructor);
+    for (const [token, constructa] of Object.entries(module.define)) {
+      registry.define(token, constructa as ShadowObjectConstructor);
     }
   }
 
@@ -33,7 +33,7 @@ export async function importModule(
   }
 
   await (module.initialize?.({
-    define: (token, constructor) => registry.define(token, constructor as ShadowObjectConstructor),
+    define: (token, constructa) => registry.define(token, constructa as ShadowObjectConstructor),
     kernel,
     registry,
   }) ?? Promise.resolve());

packages/shadow-objects/src/types.ts

@@ -187,7 +187,7 @@ export type ShadowObjectType = EventizedObject;
 export type NamespaceType = string | symbol;
 
 export type ShadowObjectsModuleInitializer = (shadowObjects: {
-  define: (token: string, constructor: ShadowObjectConstructor | ShadowObjectConstructorFunc) => void;
+  define: (token: string, constructa: ShadowObjectConstructor | ShadowObjectConstructorFunc) => void;
   kernel: Kernel;
   registry: Registry;
 }) => Promise<void>;

packages/shadow-objects/src/utils/FrameLoop.ts

@@ -6,7 +6,6 @@ export class FrameLoop {
   static OnFrame = Symbol('onFrame');
 
   #rafID = 0;
-  #subscriptionCount = 0;
 
   constructor() {
     if (gUniqInstance) return gUniqInstance;
@@ -23,8 +22,6 @@ export class FrameLoop {
 
     on(this as FrameLoop, FrameLoop.OnFrame, target);
 
-    this.#subscriptionCount++;
-
     return () => {
       this.stop(target);
     };