Allow linking to lower level in delta specs.#1598
Conversation
|
Note: the merge conflict indicated by github is a trivially resolved one. |
nschonni
left a comment
nschonni
left a comment
There was a problem hiding this comment.
Copying over the suggestions from the formatter
fantasai
force-pushed
the
delta-self
branch
2 times, most recently
from
f3d9b55 to
2054fbe
Compare
| ignoreObsoletes=True, | ||
| ) | ||
|
|
||
| if failure and self.isDelta: |
There was a problem hiding this comment.
This block doesn't do what you want. latestOnly just finds, for each dfn from each shortname, the highest-level version and then suppresses lower-level versions; if this is a delta spec that doesn't contain a term's dfn, it won't have a dfn in the results anyway so this won't have any effect.
(Also, it would only trigger if the first try completely failed; a confusable reference from another spec would prevent this from activating.)
There was a problem hiding this comment.
What you instead want to alter is the ReferenceManager.removeSameSpecRefs() function; that's what unexports all dfns from specs with the same shortname.
(But make sure you still remove refs from the same or later level, so your local copy doesn't get confused with its version in the db, and doesn't link forward to a future version of itself either.)
4 participants
No description provided.