feat: migrate to Node 24 LTS

.github/workflows/test.yml

@@ -0,0 +1,21 @@
+name: Tests
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: pnpm/action-setup@v5
+      - uses: actions/setup-node@v6
+        with:
+          node-version-file: .nvmrc
+          cache: pnpm
+      - run: pnpm install
+      - run: pnpm build
+      - run: pnpm test

.nvmrc

@@ -1 +1 @@
-20
+24

@types/import-meta.d.ts

@@ -0,0 +1,3 @@
+interface ImportMeta {
+  main: boolean;
+}

app.ts

@@ -7,7 +7,6 @@ import helmet from "helmet";
 
 import * as logging from "./utils/logging.js";
 import { register as registerViewEngine } from "./utils/view-engine.js";
-import { legacyDirname } from "./utils/misc.js";
 import { PROJECT_ROOT } from "./utils/constants.js";
 
 import xrefRouter from "./routes/xref/index.js";
@@ -28,7 +27,7 @@ app.use(logging.stderr());
 
 app.use(express.static(path.join(PROJECT_ROOT, "/static")));
 
-app.set("views", path.join(legacyDirname(import.meta), "views"));
+app.set("views", path.join(import.meta.dirname, "views"));
 registerViewEngine(app);
 
 // Security

package.json

@@ -7,6 +7,9 @@
   "author": "Marcos Caceres <marcos@marcosc.com>",
   "type": "module",
   "license": "MIT",
+  "engines": {
+    "node": ">=24"
+  },
   "dependencies": {
     "chalk": "^5.6.2",
     "compression": "^1.8.1",
@@ -16,7 +19,6 @@
     "helmet": "^8.0.0",
     "morgan": "^1.10.1",
     "nanoid": "^5.0.8",
-    "node-fetch": "^3.3.2",
     "serialize-error": "^11.0.3",
     "split2": "^4.2.0",
     "ucontent": "^2.0.0"

routes/caniuse/update.ts

@@ -1,11 +1,10 @@
 import path from "path";
 
-import { legacyDirname } from "../../utils/misc.js";
 import { BackgroundTaskQueue } from "../../utils/background-task-queue.js";
 import { cache } from "./lib/index.js";
 import { Request, Response } from "express";
 
-const workerFile = path.join(legacyDirname(import.meta), "update.worker.js");
+const workerFile = path.join(import.meta.dirname, "update.worker.js");
 const taskQueue = new BackgroundTaskQueue<typeof import("./update.worker")>(
   workerFile,
   "caniuse_update",

routes/docs/update.ts

@@ -1,7 +1,6 @@
 import path from "path";
 import { writeFile } from "fs/promises";
 
-import fetch from "node-fetch";
 import { Request, Response } from "express";
 
 import { HTTPError } from "../../utils/misc.js";

routes/github/lib/utils/graphql.ts

@@ -1,4 +1,3 @@
-import fetch from "node-fetch";
 import { getToken, updateRateLimit, RateLimit } from "./tokens.js";
 
 const ENDPOINT = "https://api.github.com/graphql";

routes/github/lib/utils/rest.ts

@@ -1,7 +1,11 @@
-import fetch, { Response } from "node-fetch";
 import { getToken, updateRateLimit, RateLimit } from "./tokens.js";
 
+const GITHUB_API_PREFIX = "https://api.github.com/";
+
 export async function* requestData(endpoint: string, pages = 30) {
+  if (!endpoint.startsWith(GITHUB_API_PREFIX)) {
+    throw new Error(`requestData: endpoint must start with ${GITHUB_API_PREFIX}`);
+  }
   let url: string | null = endpoint;
   do {
     const token = getToken();
@@ -20,7 +24,11 @@ export async function* requestData(endpoint: string, pages = 30) {
     const result = await response.json();
     yield { url, result };
 
-    url = nextPage(response.headers.get("link") || "");
+    const next = nextPage(response.headers.get("link") || "");
+    if (next !== null && !next.startsWith(GITHUB_API_PREFIX)) {
+      throw new Error(`requestData: pagination URL must start with ${GITHUB_API_PREFIX}`);
+    }
+    url = next;
     updateRateLimit(token, getRateLimit(response.headers));
   } while (url !== null && --pages > 0);
 
@@ -38,7 +46,7 @@ function nextPage(link: string) {
   return m ? m[1] : null;
 }
 
-function getRateLimit(headers: Response["headers"]): RateLimit {
+function getRateLimit(headers: Headers): RateLimit {
   return {
     remaining: parseInt(headers.get("x-ratelimit-remaining") as string, 10),
     resetAt: new Date(parseInt(headers.get("x-ratelimit-reset") as string, 10)),

routes/w3c/group.ts

@@ -1,7 +1,6 @@
 import path from "path";
 import { readFileSync } from "fs";
 
-import fetch from "node-fetch";
 import { Request, Response } from "express";
 
 import { MemCache } from "../../utils/mem-cache.js";
@@ -56,6 +55,7 @@ export default async function route(req: IRequest, res: Response) {
   }
 
   if (type && !groups.hasOwnProperty(type)) {
+    res.set("Content-Type", "text/plain");
     return res.status(404).send(`Invalid group type: "${type}".`);
   }
 

routes/well-known/pay.ts

@@ -1,5 +1,4 @@
 import { Request, Response } from "express";
-import fetch from "node-fetch";
 
 const PAYMENT_POINTERS = [
   // "$ilp.uphold.com/DwJmxPHHi8K3", // Marcos

routes/xref/update.ts

@@ -2,14 +2,13 @@ import path from "path";
 
 import { Request, Response } from "express";
 
-import { legacyDirname } from "../../utils/misc.js";
 import { BackgroundTaskQueue } from "../../utils/background-task-queue.js";
 import { ms } from "../../utils/misc.js";
 
 import { cache as searchCache } from "./lib/search.js";
 import { store } from "./lib/store-init.js";
 
-const workerFile = path.join(legacyDirname(import.meta), "update.worker.js");
+const workerFile = path.join(import.meta.dirname, "update.worker.js");
 const taskQueue = new BackgroundTaskQueue<typeof import("./update.worker")>(
   workerFile,
   "xref_update",

scripts/update-w3c-groups-list.ts

@@ -4,11 +4,9 @@
  */
 
 import path from "path";
-import { fileURLToPath } from "url";
 import { writeFile, mkdir } from "fs/promises";
 
 import "dotenv/config";
-import fetch from "node-fetch";
 
 import { env } from "../utils/misc.js";
 
@@ -122,12 +120,6 @@ export default async function update() {
   await writeFile(OUTPUT_FILE, JSON.stringify(data, null, 2), "utf-8");
 }
 
-const runAsScript = (() => {
-  const modulePath = fileURLToPath(import.meta.url);
-  const scriptPath = process.argv[1];
-  return modulePath === scriptPath;
-})();
-
-if (runAsScript) {
+if (import.meta.main) {
   await update();
 }

tests/node24-globals.test.js

@@ -0,0 +1,13 @@
+describe("Node 24 globals", () => {
+  it("fetch is available as a global", () => {
+    expect(typeof fetch).toBe("function");
+  });
+
+  it("import.meta.dirname is a string", () => {
+    expect(typeof import.meta.dirname).toBe("string");
+  });
+
+  it("import.meta.filename is a string", () => {
+    expect(typeof import.meta.filename).toBe("string");
+  });
+});

tests/utils/constants.test.js

@@ -0,0 +1,9 @@
+import { PROJECT_ROOT } from "../../build/utils/constants.js";
+import { existsSync } from "fs";
+import { join } from "path";
+
+describe("utils/constants", () => {
+  it("PROJECT_ROOT resolves to the repo root", () => {
+    expect(existsSync(join(PROJECT_ROOT, "package.json"))).toBeTrue();
+  });
+});

utils/background-task-queue.ts

@@ -7,7 +7,7 @@ import { nanoid } from "nanoid";
 import split2 from "split2";
 import { serializeError, deserializeError } from "serialize-error";
 
-import { legacyFilename, env } from "./misc.js";
+import { env } from "./misc.js";
 
 type Message = { id: string };
 
@@ -151,7 +151,7 @@ export class BackgroundTaskQueue<M extends TaskModule> {
   constructor(jobDescriptionModulePath: string, queueName: string) {
     this.modulePath = jobDescriptionModulePath;
     this.name = queueName;
-    const __filename = legacyFilename(import.meta);
+    const __filename = import.meta.filename;
     this.worker = new Worker(__filename, { stderr: true, stdout: true });
   }
 

utils/constants.ts

@@ -1,11 +1,10 @@
 import { join } from "path";
 import { readdirSync } from "fs";
-import { legacyDirname } from "./misc.js";
 
 export const isDevEnv = process.env.NODE_ENV !== "production";
 
 export const PROJECT_ROOT = (() => {
-  let currentDir = legacyDirname(import.meta);
+  let currentDir = import.meta.dirname;
   while (!readdirSync(currentDir).includes("package.json")) {
     const newCurrentDir = join(currentDir, "..");
     if (currentDir === newCurrentDir) {

utils/misc.ts

@@ -1,6 +1,3 @@
-import path from "path";
-import { fileURLToPath } from "url";
-
 /**
  * Ensure env variable exists and get its value.
  * @param name name of env variable
@@ -58,13 +55,3 @@ export class HTTPError extends Error {
     super(message);
   }
 }
-
-// __dirname
-export function legacyDirname(meta: ImportMeta) {
-  return path.dirname(fileURLToPath(meta.url));
-}
-
-// __filename
-export function legacyFilename(meta: ImportMeta) {
-  return fileURLToPath(meta.url);
-}