test: add GitHub REST utils and respec size handler tests by marcoscaceres · Pull Request #500 · speced/respec-web-services

marcoscaceres · 2026-04-25T10:36:08Z

Summary

13 specs for SSRF guard (URL validation, pagination hijack)
15 specs for respec size handler (auth, validation, dedup buffer)

Copilot

Pull request overview

Adds/expands Jasmine coverage for GitHub REST pagination/SSRF validation and the routes/respec/size handlers, to improve regression protection around URL safety, pagination behavior, and size-report persistence/deduplication.

Changes:

Adds a new test suite for routes/respec/size covering auth, input validation, file writes, truncation, dedup buffer behavior, and GET headers/body.
Expands github/lib/utils/rest tests with additional cases for endpoint validation, pagination link handling, page limits, request headers, and HTTP errors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
tests/routes/respec/size.test.js	New tests for Respec size GET/PUT handlers including env setup, file persistence, and dedup buffer behavior.
tests/routes/github/lib/utils/rest.test.js	Expanded tests for GitHub REST request generator covering SSRF guard, pagination, error handling, and request headers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

marcoscaceres · 2026-04-27T08:25:51Z

@copilot Please address and fix any outstanding commo

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/e105260b-47cc-4bb7-b3a6-a63cdfcee915

Copilot · 2026-04-27T08:28:58Z

@copilot Please address and fix any outstanding commo

Fixed in ccffa9a. The last outstanding issue was the page-limit test silently triggering console.warn — added spyOn(console, "warn") and an assertion that it's called with "Some pages were skipped" to make the behavior explicit and keep test output clean. The other two items (||= for GH_TOKEN and the URL-validation error regex) were already addressed in prior commits.

marcoscaceres · 2026-04-27T08:55:20Z

@copilot Can you review this and fix any issues that come up?

marcoscaceres · 2026-04-29T03:10:30Z

@copilot Can you confirm all your feedback has been addressed? Please resolve the threads that have been addressed and fix anything outstanding.

…e.test.js Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/f09bc44e-9e7d-4e92-bb88-6759c09bff51

Copilot · 2026-04-29T03:13:54Z

@copilot Can you confirm all your feedback has been addressed? Please resolve the threads that have been addressed and fix anything outstanding.

All feedback has been addressed. The final cleanup in 89e5652 removes the duplicate previousDataDir/previousRespecGhActionSecret variables in size.test.js (they were capturing the same values as origDataDir/origSecret) and drops the now-redundant env restoration from afterAll — env is already restored immediately after import in the finally block. All 59 specs pass.

@copilot Can you review this and fix any issues that come up?

Reviewed — found and fixed a leftover issue in size.test.js: duplicate previousDataDir/previousRespecGhActionSecret variables (shadowing the already-existing origDataDir/origSecret) and a redundant env restoration in afterAll (env is already restored in the finally block right after import). Fixed in 89e5652.

sidvishnoi · 2026-05-04T10:56:44Z

+  process.env.DATA_DIR = DATA_DIR;
+  process.env.RESPEC_GH_ACTION_SECRET = TEST_SECRET;


How about we use jasmine helpers and set all fake variables there?

Then we won't need dynamic imports etc. likely.

marcoscaceres force-pushed the test/github-respec branch from 4befb8e to cbbfbc7 Compare April 25, 2026 12:12

marcoscaceres requested a review from Copilot April 25, 2026 12:26

Copilot started reviewing on behalf of marcoscaceres April 25, 2026 12:26 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

marcoscaceres force-pushed the test/github-respec branch from cbbfbc7 to f5981a8 Compare April 25, 2026 13:25

marcoscaceres requested a review from Copilot April 25, 2026 13:25

Copilot started reviewing on behalf of marcoscaceres April 25, 2026 13:25 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tests/routes/respec/size.test.js Outdated

Comment thread tests/routes/github/lib/utils/rest.test.js

marcoscaceres requested a review from Copilot April 25, 2026 13:38

Copilot started reviewing on behalf of marcoscaceres April 25, 2026 13:38 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

test: add GitHub REST utils and respec size handler tests

d0d4ac3

marcoscaceres force-pushed the test/github-respec branch from f5981a8 to d0d4ac3 Compare April 26, 2026 00:17

marcoscaceres requested a review from Copilot April 26, 2026 01:20

Copilot started reviewing on behalf of marcoscaceres April 26, 2026 01:21 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Comment thread tests/routes/github/lib/utils/rest.test.js Outdated

marcoscaceres requested a review from Copilot April 26, 2026 03:38

Copilot started reviewing on behalf of marcoscaceres April 26, 2026 03:39 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Comment thread tests/routes/github/lib/utils/rest.test.js

Comment thread tests/routes/github/lib/utils/rest.test.js

Comment thread tests/routes/respec/size.test.js

marcoscaceres requested a review from Copilot April 26, 2026 03:58

Copilot started reviewing on behalf of marcoscaceres April 26, 2026 03:59 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Apply suggestions from code review

aad6cfb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of marcoscaceres April 27, 2026 08:26 View session

test: spy on console.warn in page-limit test and assert warning

ccffa9a

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/e105260b-47cc-4bb7-b3a6-a63cdfcee915

Copilot finished work on behalf of marcoscaceres April 27, 2026 08:31

Copilot started work on behalf of marcoscaceres April 29, 2026 03:10 View session

test: remove duplicate env vars and redundant afterAll cleanup in siz…

89e5652

…e.test.js Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/f09bc44e-9e7d-4e92-bb88-6759c09bff51

marcoscaceres marked this pull request as ready for review April 29, 2026 03:14

Copilot finished work on behalf of marcoscaceres April 29, 2026 03:14

marcoscaceres requested a review from sidvishnoi April 29, 2026 13:40

sidvishnoi reviewed May 4, 2026

View reviewed changes

		process.env.DATA_DIR = DATA_DIR;
		process.env.RESPEC_GH_ACTION_SECRET = TEST_SECRET;

Conversation

marcoscaceres commented Apr 25, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

marcoscaceres commented Apr 27, 2026

Uh oh!

Copilot AI commented Apr 27, 2026

Uh oh!

marcoscaceres commented Apr 27, 2026

Uh oh!

marcoscaceres commented Apr 29, 2026

Uh oh!

Copilot AI commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sidvishnoi May 4, 2026

Choose a reason for hiding this comment

Uh oh!

sidvishnoi May 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 29, 2026 •

edited

Loading