test: add caniuse and w3c route tests by marcoscaceres · Pull Request #501 · speced/respec-web-services

marcoscaceres · 2026-04-25T10:36:10Z

Summary

Tests for BROWSERS, DEFAULT_BROWSERS, SUPPORT_TITLES constants
Tests for sanitizeBrowsersList and getSupportTitle logic
Tests for w3c group handler (legacy shortnames, error handling, disambiguation)

Copilot

Pull request overview

Adds new Jasmine test coverage around the caniuse helper logic/constants and the w3c/group route behavior, using temporary fixture data written under a per-test DATA_DIR.

Changes:

Adds tests for caniuse constants and createResponseBody() browser filtering/version slicing.
Adds tests for w3c/group route behavior (legacy shortname redirects, content negotiation, invalid type, error paths).
Introduces temporary on-disk fixtures for caniuse/*.json and w3c/groups.json used by the routes at module load time.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
tests/routes/w3c/group.test.js	New tests for W3C group route behavior using a fixture `groups.json`.
tests/routes/caniuse/lib/index.test.js	New tests for caniuse constants and response formatting/filtering using a fixture feature JSON.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Adds a setInterval that calls the update script daily and reloads the in-memory groups data from disk. Follows the existing pattern from xref's periodic cache invalidation. Also handles missing groups.json gracefully at startup (empty store instead of crash). Closes #395

Replace setInterval with self-scheduling setTimeout so the next refresh only fires after the current one completes. Add in-flight guard for safety. On startup JSON parse failure, trigger an immediate refreshGroups() to self-heal.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/cdec1a38-dd7f-40f8-8412-42208be2c16a Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

marcoscaceres · 2026-04-27T08:19:08Z

@copilot can you resolve any unaddressed concerns

- Fix typo in SUPPORT_TITLES constant: "needs to enabled" → "needs to be enabled" - Guard afterAll in group.test.js: only rm/restore if tmpDir/origDataDir are set - Guard afterAll in caniuse index.test.js: same pattern - Move HTTPError tests from group.test.js to tests/utils/misc.test.js - Replace getSupportTitle reimplementation with actual HTML output assertions via createResponseBody({format: "html"}) using fixture data with compound and unknown support keys Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/89d0a0b8-62d6-4426-ad6a-ed304d3b1ce1

Copilot · 2026-04-27T08:28:29Z

@copilot can you resolve any unaddressed concerns

Addressed all remaining concerns in 35dc30a:

Typo fix: SUPPORT_TITLES "d" key now reads "needs to be enabled" (fixed in source + test)
afterAll guards: Both test files now guard rm(tmpDir, ...) and env restore behind if (tmpDir) / if (origDataDir !== undefined) checks
HTTPError tests moved: Extracted from group.test.js into a new tests/utils/misc.test.js
getSupportTitle tests replaced: The reimplementation was removed; tests now call createResponseBody({ format: "html" }) with fixture data (including a compound ["y","x"] entry and an unknown ["z"] entry) and assert the rendered HTML contains the expected title="..." attributes

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.w3.org
- Triggering command: /usr/local/bin/node node /home/REDACTED/work/respec-web-services/respec-web-services/node_modules/.bin/jasmine --config=tests/jasmine.json (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

marcoscaceres · 2026-04-27T08:54:23Z

@copilot Can you review this and fix any issues that come up?

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/728917e2-18ac-49b2-8ef9-9630dfdc2e9f Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

Restructured per review feedback: - Use BackgroundTaskQueue with worker thread (matches xref/caniuse) - Only write groups.json on successful scrape - Add POST /w3c/update endpoint for cron-triggered refreshes - Remove inline setTimeout/setInterval timer

Remove redundant existsSync guards (readFileSync throws into catch). Add authGithubWebhook middleware to POST /w3c/update to prevent spam. Add W3C_GROUPS_SECRET to .env.sample. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The reloadGroups() return value was silently discarded, so a successful scrape followed by a failed reload would return 200. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Tests valid reload (returns true, updates in-memory groups), missing file (returns false, preserves previous data), and corrupt JSON (returns false, preserves previous data). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

marcoscaceres · 2026-05-04T13:25:52Z

@copilot can you resolve the merge conflicts?

# Conflicts: # tests/utils/misc.test.js Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

Copilot · 2026-05-04T13:32:35Z

@copilot can you resolve the merge conflicts?

Merge conflicts resolved in a1cb402. The only conflict was in tests/utils/misc.test.js — our small HTTPError-only version vs. main's comprehensive version covering env(), seconds(), ms(), getErrnoCode, and HTTPError. Kept main's version since it's a strict superset. All 159 specs pass.

@copilot Can you review this and fix any issues that come up?

Reviewed and all tests pass (159 specs, 0 failures). No issues found after the merge with main — the code review and CodeQL scan both came back clean.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.w3.org
- Triggering command: /usr/local/bin/node node /home/REDACTED/work/respec-web-services/respec-web-services/node_modules/.bin/jasmine --config=tests/jasmine.json (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

marcoscaceres force-pushed the test/caniuse-w3c branch from edc7b8d to e977ed7 Compare April 25, 2026 12:12

marcoscaceres requested a review from Copilot April 25, 2026 12:26

Copilot started reviewing on behalf of marcoscaceres April 25, 2026 12:26 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

marcoscaceres force-pushed the test/caniuse-w3c branch from e977ed7 to 907c25f Compare April 25, 2026 13:34

marcoscaceres requested a review from Copilot April 25, 2026 13:34

Copilot started reviewing on behalf of marcoscaceres April 25, 2026 13:35 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread tests/routes/w3c/group.test.js Outdated

Comment thread tests/routes/w3c/group.test.js Outdated

Comment thread tests/routes/w3c/group.test.js Outdated

Comment thread tests/routes/caniuse/lib/index.test.js

Comment thread tests/routes/caniuse/lib/index.test.js Outdated

marcoscaceres force-pushed the test/caniuse-w3c branch 4 times, most recently from 1c1198f to ac73ae0 Compare April 26, 2026 01:06

test: add caniuse and w3c route tests

9c450d3

marcoscaceres force-pushed the test/caniuse-w3c branch from ac73ae0 to 9c450d3 Compare April 26, 2026 01:12

marcoscaceres requested a review from Copilot April 26, 2026 01:20

Copilot started reviewing on behalf of marcoscaceres April 26, 2026 01:20 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Comment thread tests/routes/w3c/group.test.js

Comment thread tests/routes/w3c/group.test.js Outdated

Comment thread tests/routes/caniuse/lib/index.test.js

marcoscaceres requested a review from Copilot April 26, 2026 03:38

Copilot started reviewing on behalf of marcoscaceres April 26, 2026 03:39 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Comment thread tests/routes/w3c/group.test.js

Comment thread tests/routes/caniuse/lib/index.test.js Outdated

marcoscaceres requested a review from Copilot April 26, 2026 03:58

Copilot started reviewing on behalf of marcoscaceres April 26, 2026 03:59 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

marcoscaceres and others added 7 commits April 27, 2026 10:31

Apply suggestions from code review

5f14fd3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

c9c92b6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

e18c1fa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

edfd844

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

4c64814

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

marcoscaceres and others added 3 commits April 27, 2026 18:07

Apply suggestion from @Copilot

8d47d75

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestions from code review

595b1b0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(w3c): clean up group.ts - fix TDZ, duplicates, add retry/backoff

06a077c

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/cdec1a38-dd7f-40f8-8412-42208be2c16a Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

Copilot started work on behalf of marcoscaceres April 27, 2026 08:19 View session

Copilot finished work on behalf of marcoscaceres April 27, 2026 08:31

marcoscaceres and others added 13 commits April 27, 2026 19:26

Apply suggestion from @Copilot

a85782b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

13f33f2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

153aa7e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply suggestion from @Copilot

be80aca

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into feat/auto-refresh-groups

1314d8a

fix(w3c): reloadGroups returns boolean, retry on any refresh failure

33c5e5f

Agent-Logs-Url: https://github.com/speced/respec-web-services/sessions/728917e2-18ac-49b2-8ef9-9630dfdc2e9f Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

Merge branch 'main' into feat/auto-refresh-groups

d3b6242

Merge branch 'main' into feat/auto-refresh-groups

c840be6

fix(w3c): return 500 when groups reload fails after update

4936436

The reloadGroups() return value was silently discarded, so a successful scrape followed by a failed reload would return 200. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge branch 'feat/auto-refresh-groups' into test/caniuse-w3c

8865a0b

test(w3c): add reloadGroups() tests

d0af01f

Tests valid reload (returns true, updates in-memory groups), missing file (returns false, preserves previous data), and corrupt JSON (returns false, preserves previous data). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

marcoscaceres marked this pull request as ready for review May 4, 2026 13:26

Copilot started work on behalf of marcoscaceres May 4, 2026 13:27 View session

Merge remote-tracking branch 'origin/main' into test/caniuse-w3c

a1cb402

# Conflicts: # tests/utils/misc.test.js Co-authored-by: marcoscaceres <870154+marcoscaceres@users.noreply.github.com>

Copilot finished work on behalf of marcoscaceres May 4, 2026 13:33

Merge branch 'main' into test/caniuse-w3c

8e98064

Conversation

marcoscaceres commented Apr 25, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

marcoscaceres commented Apr 27, 2026

Uh oh!

Copilot AI commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

marcoscaceres commented Apr 27, 2026

Uh oh!

marcoscaceres commented May 4, 2026

Uh oh!

Copilot AI commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 27, 2026 •

edited

Loading

Copilot AI commented May 4, 2026 •

edited

Loading