fix(w3c/headers): errata text, charter type, w3cid#5247
fix(w3c/headers): errata text, charter type, w3cid#5247marcoscaceres wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates W3C header rendering/validation to align with current W3C header expectations: clearer errata link text, support for “charter” status, and expanded editor W3C ID validation beyond Rec Track specs.
Changes:
- Reworded the errata link text from “Errata exists” to “Check for errata” (and updated the corresponding spec test).
- Added “charter” to known spec statuses and to the non-track status list.
- Expanded editor
w3cidvalidation to also apply to Notes and Registries (not just Rec Track).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/spec/w3c/headers-spec.js | Updates the expected errata link text in the W3C headers spec test. |
| src/w3c/templates/headers.js | Adds French localization strings and updates errata link text rendered in the header template. |
| src/w3c/headers.js | Adds “charter” status handling and broadens w3cid validation to additional spec types. |
Comments suppressed due to low confidence (1)
src/w3c/templates/headers.js:1
- The errata link text is still hard-coded in English. Since this file already supports localized header strings, consider moving “Check for errata” into the localization table (e.g., a new
check_for_erratakey) and render it via the existing localization mechanism. This keeps header text consistent across locales and avoids future in-template string edits.
// @ts-check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e66da25 to
6ed20e9
Compare
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
All feedback is addressed and all CI checks (Check PR title, CodeQL, Node CI) are passing on |
Closes #4446
Closes #3570
Closes #4073