Skip to content

fix(w3c/headers): errata text, charter type, w3cid#5247

Open
marcoscaceres wants to merge 2 commits intomainfrom
fix/4446-errata-headers
Open

fix(w3c/headers): errata text, charter type, w3cid#5247
marcoscaceres wants to merge 2 commits intomainfrom
fix/4446-errata-headers

Conversation

@marcoscaceres
Copy link
Copy Markdown
Contributor

Closes #4446
Closes #3570
Closes #4073

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates W3C header rendering/validation to align with current W3C header expectations: clearer errata link text, support for “charter” status, and expanded editor W3C ID validation beyond Rec Track specs.

Changes:

  • Reworded the errata link text from “Errata exists” to “Check for errata” (and updated the corresponding spec test).
  • Added “charter” to known spec statuses and to the non-track status list.
  • Expanded editor w3cid validation to also apply to Notes and Registries (not just Rec Track).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/spec/w3c/headers-spec.js Updates the expected errata link text in the W3C headers spec test.
src/w3c/templates/headers.js Adds French localization strings and updates errata link text rendered in the header template.
src/w3c/headers.js Adds “charter” status handling and broadens w3cid validation to additional spec types.
Comments suppressed due to low confidence (1)

src/w3c/templates/headers.js:1

  • The errata link text is still hard-coded in English. Since this file already supports localized header strings, consider moving “Check for errata” into the localization table (e.g., a new check_for_errata key) and render it via the existing localization mechanism. This keeps header text consistent across locales and avoids future in-template string edits.
// @ts-check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/w3c/headers.js
- Change 'Errata exists' to 'Check for errata' (#4446)
- Add 'charter' as a document type (#3570)
- Require w3cid for Note and Registry track editors (#4073)

Closes #4446
Closes #3570
Closes #4073
@marcoscaceres marcoscaceres force-pushed the fix/4446-errata-headers branch from e66da25 to 6ed20e9 Compare May 4, 2026 07:40
@marcoscaceres
Copy link
Copy Markdown
Contributor Author

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

@marcoscaceres
Copy link
Copy Markdown
Contributor Author

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed?

All feedback is addressed and all CI checks (Check PR title, CodeQL, Node CI) are passing on c9f1133. The one outstanding request — test coverage for w3cid enforcement in Notes and Registries — was resolved in c9f1133 with test loops for all W3CNotes and registryTrackStatus statuses.

@marcoscaceres marcoscaceres marked this pull request as ready for review May 9, 2026 02:40
@marcoscaceres marcoscaceres requested review from sidvishnoi and removed request for sidvishnoi May 9, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading errata links error if w3cid is missing for all TR docs Support "charter" as a w3c document type

3 participants