fix(linter): exclude .introductory from headingless check#5249
fix(linter): exclude .introductory from headingless check#5249marcoscaceres wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the no-headingless-sections linter rule to exclude “introductory” sections from the heading requirement (per #4201).
Changes:
- Excludes
section.introductoryfrom the headingless-sections query selector. - Adds a spec ensuring introductory sections without headings do not trigger warnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/spec/core/linter-rules/no-headingless-sections-spec.js | Adds test coverage for excluding .introductory sections from warnings. |
| src/core/linter-rules/no-headingless-sections.js | Updates selector to skip .introductory sections during linting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h2>Normal section</h2> | ||
| </section> | ||
| `; | ||
| const opts = makeStandardOps(config, body); |
There was a problem hiding this comment.
makeStandardOps is the correct name — it's exported from tests/spec/SpecHelper.js. Not a typo.
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
All feedback has been addressed. The only review comment was about |
Closes #4201