fix(core/xref-db): skip caching empty xref results#5260
Open
marcoscaceres wants to merge 4 commits intospeced:mainfrom
Open
fix(core/xref-db): skip caching empty xref results#5260marcoscaceres wants to merge 4 commits intospeced:mainfrom
marcoscaceres wants to merge 4 commits intospeced:mainfrom
Conversation
When the xref API returns no result for a query, `cacheXrefData()` was storing an empty array in IDB. On subsequent loads, the cache hit prevented re-fetching, permanently suppressing results for terms that were temporarily missing from the API. Skip caching queries with no results so they are re-fetched next time. Closes speced#5256
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes core/xref-db’s IndexedDB caching behavior so that “no results” responses from the xref API don’t get cached and block future refetches, addressing #5256.
Changes:
- Stop writing entries to IDB when a query’s xref result is empty (
[]). - Ensure missing/empty results will be re-fetched on subsequent runs instead of being treated as a cache hit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address Copilot feedback: resolveXrefCache now uses a readwrite transaction that deletes empty-result entries it encounters, recovering from previously cached empty arrays.
Two tests using real IDB: 1. Queries with empty results are not cached (write path) 2. Pre-existing empty cache entries are deleted on read (migration) Address Copilot feedback requesting test coverage.
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
1 similar comment
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5256
When the xref API returns no result for a query, `cacheXrefData()` stored an empty array in IDB. On subsequent loads, the cache hit prevented re-fetching, permanently suppressing results for terms that were temporarily missing from the API.
Skips caching queries with no results so they are re-fetched next time.