fix(styles): remove inline-block from issue summary list items#5262
Open
marcoscaceres wants to merge 2 commits intospeced:mainfrom
Open
fix(styles): remove inline-block from issue summary list items#5262marcoscaceres wants to merge 2 commits intospeced:mainfrom
marcoscaceres wants to merge 2 commits intospeced:mainfrom
Conversation
`#issue-summary li { display: inline-block }` caused title-less issues
to collapse onto the same line ("Issue 2Issue 3" with no separation).
The 2-column layout is handled by `column-count: 2` on the parent
`<ul>`, so the `inline-block` was unnecessary.
Closes speced#3942
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ReSpec’s bundled stylesheet to prevent issue-summary list items from collapsing onto the same line when an issue has no title, while preserving the existing 2-column layout on the parent <ul>.
Changes:
- Remove
display: inline-blockfrom#issue-summary liso each issue renders on its own line. - Keep the 2-column layout driven by
column-count: 2on#issue-summary > ul.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
1 similar comment
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3942
#issue-summary li { display: inline-block }caused title-less issues to collapse onto the same line (e.g., "Issue 2Issue 3" with no separation). The 2-column layout is handled bycolumn-count: 2on the parent<ul>, so theinline-blockwas unnecessary.Before (title-less issues smashed together):
After (each issue on its own line within the 2-column layout):
