Extra warnings

Author: JR-Morgan

Directory.Build.props

@@ -36,20 +36,12 @@
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <!-- Ingored warnings, some aspirational but too noisy for now, some by design.  -->
     <NoWarn>
-      <!--Disabled by design-->
-      CA5399;CA1812;
       <!--XML comment-->
       CS1591;CS1573;
       <!-- Globalization rules -->
       CA1303;CA1304;CA1305;CA1307;CA1308;CA1309;CA1310;CA1311;
       <!-- Logging -->
       CA1848;CA1727;
-      <!-- Others we don't want -->
-      CA1815;CA1725;
-      <!-- Naming things is hard enough -->
-      CA1710;CA1711;CA1720;CA1724;
-      <!-- Aspirational -->
-      CA1502;CA1716;NETSDK1206;
       $(NoWarn)
     </NoWarn
     >

GrasshopperAsyncComponent/GH_AsyncComponent.cs

@@ -177,7 +177,7 @@ protected override void ExpireDownStreamObjects()
         }
     }
 
-    protected override void SolveInstance(IGH_DataAccess da)
+    protected override void SolveInstance(IGH_DataAccess DA)
     {
         //return;
         if (_state == 0)
@@ -191,10 +191,10 @@ protected override void SolveInstance(IGH_DataAccess da)
             // Add cancellation source to our bag
             var tokenSource = new CancellationTokenSource();
 
-            var currentWorker = BaseWorker.Duplicate($"Worker-{da.Iteration}", tokenSource.Token);
+            var currentWorker = BaseWorker.Duplicate($"Worker-{DA.Iteration}", tokenSource.Token);
 
             // Let the worker collect data.
-            currentWorker.GetData(da, Params);
+            currentWorker.GetData(DA, Params);
 
             var currentRun = new Task<Task>(
                 async () =>
@@ -226,7 +226,7 @@ protected override void SolveInstance(IGH_DataAccess da)
         if (_workers.Count > 0)
         {
             Interlocked.Decrement(ref _state);
-            _workers[_state].Instance.SetData(da);
+            _workers[_state].Instance.SetData(DA);
         }
 
         if (_state != 0)