async void if we're not going to actually await it

Author: JR-Morgan

GrasshopperAsyncComponent/GH_AsyncComponent.cs

@@ -188,7 +188,7 @@ protected override void SolveInstance(IGH_DataAccess da)
             // Let the worker collect data.
             currentWorker.GetData(da, Params);
 
-            var currentRun = new Task<Task>(
+            var currentRun = new Task(
                 async () =>
                 {
                     await currentWorker.DoWork(_reportProgress, Done).ConfigureAwait(true);

GrasshopperAsyncComponent/WorkerInstance.cs

@@ -30,7 +30,7 @@ public abstract class WorkerInstance<T>(T parent, string id, CancellationToken c
     /// <b>Make sure you always check as frequently as you can if <see cref="WorkerInstance{T}.CancellationToken"/> is cancelled. For an example, see the PrimeCalculatorWorker example.</b>
     /// </summary>
     /// <param name="reportProgress">Call this to report progress up to the parent component.</param>
-    public abstract Task DoWork(Action<string, double> reportProgress, Action done);
+    public abstract void DoWork(Action<string, double> reportProgress, Action done);
 
     /// <summary>
     /// Write your data setting logic here. <b>Do not call this function directly from this class. It will be invoked by the parent <see cref="GH_AsyncComponent{T}"/> after you've called `Done` in the <see cref="DoWork"/> function.</b>

GrasshopperAsyncComponentDemo/SampleImplementations/Sample_PrimeCalculatorAsyncComponent.cs

@@ -58,7 +58,7 @@ public PrimeCalculatorWorker(
         )
             : base(parent, id, cancellationToken) { }
 
-        public override Task DoWork(Action<string, double> reportProgress, Action done)
+        public override void DoWork(Action<string, double> reportProgress, Action done)
         {
             try
             {
@@ -70,11 +70,9 @@ public override Task DoWork(Action<string, double> reportProgress, Action done)
                 //No need to call `done()` - GrasshopperAsyncComponent assumes immediate cancel,
                 //thus it has already performed clean-up actions that would normally be done on `done()`
             }
-
-            return Task.CompletedTask;
         }
 
-        public void CalculatePrimes(Action<string, double> reportProgress)
+        private void CalculatePrimes(Action<string, double> reportProgress)
         {
             // 👉 Checking for cancellation!
             CancellationToken.ThrowIfCancellationRequested();

GrasshopperAsyncComponentDemo/SampleImplementations/Sample_UslessCyclesComponent.cs

@@ -26,7 +26,7 @@ private sealed class UselessCyclesWorker(
     {
         private int MaxIterations { get; set; } = 100;
 
-        public override Task DoWork(Action<string, double> reportProgress, Action done)
+        public override void DoWork(Action<string, double> reportProgress, Action done)
         {
             try
             {
@@ -38,11 +38,9 @@ public override Task DoWork(Action<string, double> reportProgress, Action done)
                 //No need to call `done()` - GrasshopperAsyncComponent assumes immediate cancel,
                 //thus it has already performed clean-up actions that would normally be done on `done()`
             }
-
-            return Task.CompletedTask;
         }
 
-        public void RunUselessCycles(Action<string, double> reportProgress)
+        private void RunUselessCycles(Action<string, double> reportProgress)
         {
             // Checking for cancellation
             CancellationToken.ThrowIfCancellationRequested();