feat!: STJ Experiment#1370
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #1370 +/- ##
==========================================
- Coverage 31.93% 31.41% -0.52%
==========================================
Files 115 116 +1
Lines 3285 3339 +54
Branches 358 365 +7
==========================================
Hits 1049 1049
- Misses 2197 2251 +54
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We should also test Grasshopper, and Rhino under .net7 (rather than .net8) |
|
Fixed by downgrading System.Memory from 4.5.5 -> 4.5.3 |
|
Current status: no reports of problems currently, but we haven't seen that many downloads yet. so I want to give this longer to simmer. |
…rovements-placeholder
see specklesystems/speckle-sharp-sdk#468 for the SDK changes.
This PR updates this repo to use the new System.Text.Json (STJ) powered SDK.
See https://www.notion.so/speckle/Introducing-System-Text-Json-to-packfile-based-serializer-SendPipleine-357b78fc7aa6805bb472ca09b980b7fd for context.
PR Round 2
The first version of this PR bumped the minimum version of the SDK to 8.0.0. This was bad for several reasons.
(compatibility with older Revit plugins, and potentially dangerous situations in Rhino .NET7/4.8)
This this new version of the PR is far more safe. Our min compatible STJ version is now 5.0.0; (same as what v2 connectors used). No longer conflicts with any other plugins.
Downsides are pretty minimal, it does limit our SDK to 5.0.0 API, but this is workable.
For .NET 8/10 targets
main, we're good.For .NET4.8 (including Rhino8):