hex convert

Author: JR-Morgan

src/Speckle.Sdk/Pipelines/Send/IdGenerator.cs

@@ -15,14 +15,17 @@ public static string ComputeId(ReadOnlySpan<byte> input)
     Span<byte> hash = stackalloc byte[SHA256.HashSizeInBytes];
     SHA256.HashData(input, hash);
 
+#if NET9_0_OR_GREATER
+    return Convert.ToHexStringLower(hash);
+#else
     Span<char> output = stackalloc char[HashUtility.HASH_LENGTH];
 
     for (int i = 0, j = 0; j < HashUtility.HASH_LENGTH; i += sizeof(byte), j += sizeof(char))
     {
       hash[i].TryFormat(output[j..], out _, "x2");
     }
-
     return new string(output);
+#endif
   }
 #endif
 

src/Speckle.Sdk/Pipelines/Send/Serializer.cs

@@ -115,22 +115,14 @@ private IEnumerable<PropertyInfo> ExtractProperties(Base baseObj)
       SerializeValue(prop.Value, jsonWriter, prop.IsDetachable, childClosures, detachedObjects);
     }
 
+    // We want to hash the json string now to calculate the id
+    // We don't want to allocate a separate buffer for it, as this wouldn't be memory efficient
     jsonWriter.Flush();
 
 #if NET6_0_OR_GREATER
-    // We want to hash the json string now to calculate the id
-    // We don't want to allocate a separate buffer for it, as this wouldn't be memory efficient
-    // It's also (debatably) important that the bytes we hash are the full json object (minus id and closures obviously)
-    // For this, we are manually writing the closing } bracket without calling Buffer.Advance
-    // Such that, the buffer can continue to write the id, and closures later in this function.
-    // var bytes = efficientJson.Buffer.GetSpan(1);
-    // bytes[0] = (byte)'}';
     string id = IdGenerator.ComputeId(efficientJson.WrittenSpan);
-    string str = Encoding.UTF8.GetString(efficientJson.WrittenSpan);
 #else
-
     string id = IdGenerator.ComputeId(efficientJson.GetInternalBuffer(), 0, efficientJson.WrittenCount);
-    string str = Encoding.UTF8.GetString(efficientJson.GetInternalBuffer());
 #endif
     jsonWriter.WriteString("id", id);