feat!: Use STJ for SendPipeline serializer instead of Newtonsoft#468
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 68.38% 73.70% +5.32%
==========================================
Files 357 367 +10
Lines 14379 14747 +368
Branches 1210 1219 +9
==========================================
+ Hits 9833 10870 +1037
+ Misses 4145 3470 -675
- Partials 401 407 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JR-Morgan
force-pushed
the
jrm/stj-experiment
branch
from
4558f3e to
72f6898
Compare
JR-Morgan
force-pushed
the
jrm/stj-experiment
branch
from
ea0a9ed to
87dc3ac
Compare
JR-Morgan
commented
Apr 17, 2026
JR-Morgan
commented
Apr 17, 2026
oguzhankoral
previously approved these changes
May 11, 2026
bimgeek
approved these changes
Jun 4, 2026
bjoernsteinhagen
approved these changes
Jun 4, 2026
oguzhankoral
added a commit
that referenced
this pull request
Jul 1, 2026
Brings in #468 (STJ SendPipeline serializer), new DataObject types (TSD, Microstation), Collection required-name (#496), OTEL/logging, and dependency bumps. Conflict resolution: - Speckle.Sdk.csproj: keep System.Text.Json 9.0.10 (our 4.0 Parquet.Net artefact writer mandates it; supersedes main's 5.0.2 pin) + main's NoWarn=NU1903. Backward-compatible with the merged STJ serializer. - 11 packages.lock.json: regenerated via `dotnet restore --force-evaluate`. - Semantic fix: ObjectsArtifactReader used the now-obsolete Collection(string)/Layer(string) ctors (#496) -> switched to parameterless + required `name` initializer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is change to replace newtonsoft with System.Text.Json for the new send pipeline serializer
See https://www.notion.so/speckle/Introducing-System-Text-Json-to-packfile-based-serializer-SendPipleine-357b78fc7aa6805bb472ca09b980b7fd
for the full context.
This PR started of a as a bit of an experimental change, since it's a significant refactor that introduces a new dependency for the .NET Standard2.0 target.
We've had this PR already deployed to our Automate powered file importers for the best part of a month.
And the connectors have already been released as betas.
Serializer Benchmarks
Medium size model: https://app.speckle.systems/projects/bf5b49215c/models/0d573b9a34
NET 10
NET 8.0
NET 4.8
Larger model (conf)
NET10
NET 4.8.1
TODO:
I'm expecting the .NET8 and .NET 10 targets to be most benefited.✅Memory allocations should be measurably lower.✅Raw speed should also be improved too✅.netstandard2.0 less so (I'm not expecting any regressions, but we should test)✅for .netstandard2.0 we've introduced a dependency on STJ. Lets determine if this will be a problem. we may be able work around it with ILRepack, or by lowering the version requirement.✅ - version lowered down to 5.xEnsure test coverage of the simple stuff (id generation etc...)✅IL repack System.Memory? or no?❎Can't since we need to expose theIBufferWriterinterface from Speckle.Sdk.Depedencies + no need, STJ pulls it in anyway.