Fix SelectionPrompt search failing with bracket characters#2059
Closed
1PetarVujakovic wants to merge 6 commits into
Closed
Fix SelectionPrompt search failing with bracket characters#20591PetarVujakovic wants to merge 6 commits into
1PetarVujakovic wants to merge 6 commits into
Conversation
Fix SelectionPrompt search failing with bracket characters
|
Is this issue related to #2055? |
Contributor
Author
Contributor
|
Wouldn't this PR prevent markup from being used at all in list items? Or am I misunderstanding something? |
Contributor
|
Closing this until merge conflicts are resolved and things are building. Feel free to re-open once this is done 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1653
Changes
Fix an issue where searching in SelectionPrompt would throw an exception when choices contained bracket characters like "[]".
The text was not properly escaped before being rendered as markup, which caused the markup parser to fail.
This change ensures that the text is safely escaped before rendering.
A unit test was added to reproduce and verify the behavior.