[DRAFT] Redesign/datasets ICA addition

[vmcru]

added ica as dynamic item to preprocessing pipeline. uses BIDSPath and exposes method and other features. still has issues with the use of caching.

[bruAristimunha]

Move this to the other PR.

[Drew-Wagner]

Thanks for this Victor! Here are my recommendations

[Drew-Wagner]

Suggested change

	def process(
	self, raw: mne.io.RawArray, raw_path: Union[str, Path]
	) -> mne.io.RawArray:
	"""Process raw data with ICA, computing or loading from cache."""
	ica_path = self.get_ica_path(raw_path)
	if not ica_path.exists():
	ica = self.compute_ica(raw, ica_path)
	else:
	ica = mne.preprocessing.read_ica(ica_path, verbose="ERROR")
	# Create a copy of the raw data before applying ICA
	raw_ica = raw.copy()
	ica.apply(raw_ica)
	return raw_ica
	@property
	def dynamic_item(self):
	@takes("raw", "fpath")
	@provides("raw", "ica_path")
	def process(
	raw: mne.io.RawArray, fpath: Union[str, Path]
	):
	"""Process raw data with ICA, computing or loading from cache."""
	ica_path = self.get_ica_path(fpath)
	if not ica_path.exists():
	ica = self.compute_ica(raw, ica_path)
	else:
	ica = mne.preprocessing.read_ica(ica_path, verbose="ERROR")
	# Create a copy of the raw data before applying ICA
	raw_ica = raw.copy()
	ica.apply(raw_ica)
	yield raw_ica
	yield ica_path
	return process

[bruAristimunha]

function inside one function is not super nice

[Drew-Wagner]

I think it is necessary though for it to work with the @takes and @provides decorators.

[bruAristimunha]

Suggested change

	bids_path.root = bids_path.root / ".." / "derivatives" / folder_name
	# Keep the same base entities:
	bids_path.update(
	suffix="eeg", # override or confirm suffix
	extension=".fif",
	description=desc, # <-- This sets a desc=ica entity
	check=True, # If you do not want BIDSPath to fail on derivative checks
	)
	ica_path = bids_path.update(
	processing="ica", suffix="ica"
	)

[Drew-Wagner]

The base branch should be redesign/datasets since it depends on those features. It should automatically update when the #55 gets merged.

[bruAristimunha]

Thank you @vmcru!!!