chore(e2e): reorganize specs by feature

Author: pallyoung

e2e/fixtures/app-entry.ts

@@ -0,0 +1,71 @@
+import { expect, type Locator, type Page } from "@playwright/test";
+import { translatePatternForE2E } from "./i18n.js";
+import {
+  expectOpenWorkspaceButton,
+  expectSettingsButton,
+  expectWelcomeCopy,
+} from "./phase1-i18n.js";
+
+export const APP_ENTRY_SELECTOR =
+  ".welcome-container, .workspace-page, .agent-draft-launcher, .session-card.agent-pane[data-session-id]";
+
+export async function expectAppEntry(page: Page): Promise<void> {
+  await expect(page.locator(APP_ENTRY_SELECTOR).first()).toBeVisible();
+}
+
+export async function isWelcomeVisible(page: Page): Promise<boolean> {
+  return await page
+    .locator(".welcome-container")
+    .isVisible()
+    .catch(() => false);
+}
+
+export async function expectWelcomeCardIfVisible(page: Page): Promise<void> {
+  await expectAppEntry(page);
+  if (await isWelcomeVisible(page)) {
+    await expect(page.locator(".welcome-card")).toBeVisible();
+  }
+}
+
+export async function expectWelcomeCopyIfVisible(page: Page): Promise<void> {
+  await expectAppEntry(page);
+  if (await isWelcomeVisible(page)) {
+    await expectWelcomeCopy(page);
+  }
+}
+
+export async function expectPrimaryWorkspaceAction(page: Page): Promise<Locator> {
+  await expectAppEntry(page);
+
+  const welcomeButton = page.locator(".welcome-btn").first();
+  if (await welcomeButton.isVisible().catch(() => false)) {
+    await expectOpenWorkspaceButton(welcomeButton);
+    return welcomeButton;
+  }
+
+  const newWorkspaceButton = page
+    .getByRole("button", {
+      name: translatePatternForE2E("tooltip.new_workspace"),
+    })
+    .first();
+  await expect(newWorkspaceButton).toBeVisible();
+  return newWorkspaceButton;
+}
+
+export async function expectSettingsEntryPoint(page: Page): Promise<Locator> {
+  await expectAppEntry(page);
+
+  const welcomeSettings = page.locator(".welcome-link").first();
+  if (await welcomeSettings.isVisible().catch(() => false)) {
+    await expectSettingsButton(welcomeSettings);
+    return welcomeSettings;
+  }
+
+  const settingsButton = page
+    .getByRole("button", {
+      name: translatePatternForE2E("action.settings"),
+    })
+    .first();
+  await expect(settingsButton).toBeVisible();
+  return settingsButton;
+}

e2e/fixtures/i18n.ts

@@ -58,3 +58,17 @@ export function translateForE2E(
 
   return text;
 }
+
+function escapeRegExp(value: string): string {
+  return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+
+export function translatePatternForE2E(
+  key: E2ETranslationKey,
+  params?: Record<string, string | number>
+): RegExp {
+  const en = translateForE2E(key, "en", params);
+  const zh = translateForE2E(key, "zh", params);
+  const values = [...new Set([en, zh])].map(escapeRegExp);
+  return new RegExp(`^(?:${values.join("|")})$`);
+}

e2e/playwright.config.ts

@@ -11,6 +11,11 @@ const sandboxDir =
   mkdtempSync(join(tmpdir(), "coder-studio-phase1-acceptance-"));
 const dataDir = process.env.CODER_STUDIO_PHASE1_DATA_DIR ?? join(sandboxDir, "coder-studio.db");
 const runtimeDir = process.env.CODER_STUDIO_PHASE1_RUNTIME_DIR ?? join(sandboxDir, "runtime");
+const providerMockDir =
+  process.env.CODER_STUDIO_E2E_PROVIDER_MOCK_DIR ?? join(sandboxDir, "provider-mock");
+const providerMockBinDir = join(providerMockDir, "bin");
+const providerMockStatePath = join(providerMockDir, "state.json");
+const providerMockDebugLogPath = join(providerMockDir, "debug.log");
 
 async function reservePort(host: string): Promise<number> {
   return await new Promise<number>((resolve, reject) => {
@@ -53,6 +58,7 @@ if (ownsPhase1Sandbox) {
   process.env.CODER_STUDIO_PHASE1_RUNTIME_DIR = runtimeDir;
   process.env.CODER_STUDIO_PHASE1_SERVER_PORT = String(SERVER_PORT);
   process.env.CODER_STUDIO_PHASE1_WEB_PORT = String(WEB_PORT);
+  process.env.CODER_STUDIO_E2E_PROVIDER_MOCK_DIR = providerMockDir;
 
   process.on("exit", () => {
     rmSync(sandboxDir, { recursive: true, force: true });
@@ -80,6 +86,10 @@ export default defineConfig({
         DATA_DIR: dataDir,
         RUNTIME_DIR: runtimeDir,
         NO_AUTH: "true",
+        CODER_STUDIO_E2E_PROVIDER_STATE_PATH: providerMockStatePath,
+        CODER_STUDIO_E2E_PROVIDER_BIN_DIR: providerMockBinDir,
+        CODER_STUDIO_E2E_PROVIDER_DEBUG_LOG_PATH: providerMockDebugLogPath,
+        PATH: `${providerMockBinDir}:${process.env.PATH ?? ""}`,
       },
     },
     {

e2e/specs/phase1/command-palette.spec.ts …/specs/app-shell/command-palette.spec.tse2e/specs/phase1/command-palette.spec.ts renamed to e2e/specs/app-shell/command-palette.spec.ts e2e/specs/phase1/command-palette.spec.ts renamed to e2e/specs/app-shell/command-palette.spec.ts

@@ -0,0 +1,16 @@
+import { expect, test } from "@playwright/test";
+import { expectAppEntry, expectWelcomeCopyIfVisible } from "../../fixtures/app-entry";
+
+test.describe("@phase1 focus mode acceptance", () => {
+  test("F1-27 enter focus", async ({ page }) => {
+    await page.goto("/");
+    // Smoke check that the root shell resolves.
+    await expectAppEntry(page);
+  });
+
+  test("F1-28 exit focus", async ({ page }) => {
+    await page.goto("/");
+    // Only assert welcome copy when "/" lands on the welcome shell.
+    await expectWelcomeCopyIfVisible(page);
+  });
+});

e2e/specs/app-shell/focus-mode.spec.ts

@@ -1,4 +1,5 @@
 import { expect, test } from "@playwright/test";
+import { expectAppEntry, isWelcomeVisible } from "../../fixtures/app-entry";
 import { translateForE2E } from "../../fixtures/i18n";
 import {
   openSettingsSection,
@@ -36,8 +37,8 @@ test.describe("@phase2 i18n acceptance", () => {
   test("P2I-03 all UI text uses translation", async ({ page }) => {
     await page.goto("/");
 
-    // Check that welcome screen text is visible (uses translation)
-    await expect(page.locator(".welcome-container")).toBeVisible();
+    // "/" may restore the last workspace instead of showing welcome.
+    await expectAppEntry(page);
 
     // Navigate to settings
     await page.goto("/settings");
@@ -47,8 +48,10 @@ test.describe("@phase2 i18n acceptance", () => {
   test("P2I-04 fallback to default language", async ({ page }) => {
     await page.goto("/");
 
-    // Welcome screen should show content
-    await expect(page.locator(".welcome-container")).toBeVisible();
-    await expect(page.locator(".welcome-title")).toBeVisible();
+    // The root shell should render, and welcome title should exist when welcome is active.
+    await expectAppEntry(page);
+    if (await isWelcomeVisible(page)) {
+      await expect(page.locator(".welcome-title")).toBeVisible();
+    }
   });
 });

e2e/specs/phase2/i18n.spec.ts e2e/specs/app-shell/i18n.spec.tse2e/specs/phase2/i18n.spec.ts renamed to e2e/specs/app-shell/i18n.spec.ts

@@ -1,7 +1,10 @@
+import * as fs from "node:fs";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
 import { expect, test } from "@playwright/test";
-import * as fs from "fs";
 
-const SCREENSHOTS_DIR = "/home/spencer/workspace/coder-studio/e2e-screenshots";
+const REPO_ROOT = join(dirname(fileURLToPath(import.meta.url)), "..", "..", "..");
+const SCREENSHOTS_DIR = join(REPO_ROOT, "e2e-screenshots");
 
 function ensureDir() {
   if (!fs.existsSync(SCREENSHOTS_DIR)) {

e2e/specs/phase3/multi-tab-visual.spec.ts …specs/app-shell/multi-tab-visual.spec.tse2e/specs/phase3/multi-tab-visual.spec.ts renamed to e2e/specs/app-shell/multi-tab-visual.spec.ts e2e/specs/phase3/multi-tab-visual.spec.ts renamed to e2e/specs/app-shell/multi-tab-visual.spec.ts

@@ -1,16 +1,17 @@
 import { expect, test } from "@playwright/test";
+import { expectAppEntry, expectWelcomeCardIfVisible } from "../../fixtures/app-entry";
 
 test.describe("@phase1 websocket acceptance", () => {
   test("F1-29 connect", async ({ page }) => {
     await page.goto("/");
-    // Page loads correctly
-    await expect(page.locator(".welcome-container")).toBeVisible();
+    // Root shell should load regardless of restore path.
+    await expectAppEntry(page);
   });
 
   test("F1-30 message flow", async ({ page }) => {
     await page.goto("/");
-    // Check welcome card
-    await expect(page.locator(".welcome-card")).toBeVisible();
+    // Validate welcome chrome only when the welcome shell is active.
+    await expectWelcomeCardIfVisible(page);
   });
 
   test("F1-31 reconnect", async ({ page }) => {