fix supervisor rollback and busy state

Author: pallyoung

.changeset/sharp-bottles-yawn.md

@@ -0,0 +1,5 @@
+---
+"@spencer-kit/coder-studio": patch
+---
+
+Fix supervisor creation rollback when target files fail, and keep manual trigger disabled while an earlier supervisor cycle is still in flight.

packages/server/src/__tests__/supervisor-manager.test.ts

@@ -373,6 +373,26 @@ describe("SupervisorManager cycle triggers", () => {
     expect(managerInternals.evaluator.logger).toBe(deps.logger);
   });
 
+  it("deletes the persisted supervisor when create target files fails", async () => {
+    const createTargetFilesError = new Error("disk full");
+    deps.targetStore.createTargetFiles.mockImplementationOnce(async () => {
+      throw createTargetFilesError;
+    });
+
+    await expect(
+      manager.create({
+        sessionId: "sess-create-fails",
+        workspaceId: "ws-1",
+        objective: "Ship the fix",
+        evaluatorProviderId: "codex",
+      })
+    ).rejects.toThrow("disk full");
+
+    expect(deps.supervisorRepo.delete).toHaveBeenCalledWith(expect.any(String));
+    expect(manager.getBySession("sess-create-fails")).toBeUndefined();
+    expect(deps.supervisorRepo.getBySessionId("sess-create-fails")).toBeUndefined();
+  });
+
   it("returns an in-flight cycle immediately on manual triggerEvaluation", async () => {
     const supervisor = await manager.create({
       sessionId: "sess-manual",

packages/server/src/supervisor/manager.ts

@@ -387,15 +387,21 @@ export class SupervisorManager {
         updatedAt: now,
       })
     );
-    await this.deps.targetStore.createTargetFiles(workspace.path, {
-      targetId,
-      sessionId: req.sessionId,
-      workspaceId: req.workspaceId,
-      objective,
-      createdAt: now,
-    });
+    let enriched: Supervisor;
+    try {
+      await this.deps.targetStore.createTargetFiles(workspace.path, {
+        targetId,
+        sessionId: req.sessionId,
+        workspaceId: req.workspaceId,
+        objective,
+        createdAt: now,
+      });
 
-    const enriched = await this.attachTargetState(supervisor, workspace.path);
+      enriched = await this.attachTargetState(supervisor, workspace.path);
+    } catch (error) {
+      this.deps.supervisorRepo.delete(supervisor.id);
+      throw error;
+    }
 
     this.storeSnapshot(enriched);
     this.broadcastState(enriched, "created");

packages/web/src/features/supervisor/actions/use-supervisor-actions.ts

@@ -102,6 +102,9 @@ export function useSupervisorActions({ sessionId }: UseSupervisorActionsArgs) {
     : ([] as SupervisorCycle[]);
 
   const latestCycle = cycles[0];
+  const hasInFlightCycle = cycles.some(
+    (cycle) => cycle.status === "evaluating" || cycle.status === "queued"
+  );
   const latestCycleText = latestCycle
     ? (latestCycle.result ??
       latestCycle.errorReason ??
@@ -166,7 +169,8 @@ export function useSupervisorActions({ sessionId }: UseSupervisorActionsArgs) {
     handlePause,
     handleResume,
     handleTrigger,
-    isBusy: supervisor?.state === "evaluating" || supervisor?.state === "injecting",
+    isBusy:
+      supervisor?.state === "evaluating" || supervisor?.state === "injecting" || hasInFlightCycle,
     latestCycle,
     latestCycleText,
     planGeneratedLabel,

packages/web/src/features/supervisor/components/supervisor-card.test.tsx

@@ -332,6 +332,49 @@ describe("SupervisorCard", () => {
     expect(screen.getByRole("button", { name: "Pause" })).not.toBeDisabled();
   });
 
+  it("keeps manual trigger disabled while an older cycle is still evaluating", () => {
+    const store = createStore();
+    window.localStorage.setItem("ui.locale", JSON.stringify("en"));
+    store.set(localeAtom, "en");
+    store.set(wsClientAtom, { sendCommand: vi.fn() } as never);
+    store.set(
+      supervisorsAtom,
+      new Map([
+        [
+          "sess-1",
+          {
+            ...createSupervisor(),
+            state: "idle",
+            objective: "Finish the follow-up refactor",
+          },
+        ],
+      ])
+    );
+    store.set(
+      supervisorCyclesAtom,
+      new Map([
+        [
+          "sup-1",
+          [
+            createCycle({
+              status: "evaluating",
+              objective: "Finish the original refactor",
+              completedAt: undefined,
+            }),
+          ],
+        ],
+      ])
+    );
+
+    render(
+      <Provider store={store}>
+        <SupervisorCard sessionId="sess-1" workspaceId="ws-1" />
+      </Provider>
+    );
+
+    expect(screen.getByRole("button", { name: "Trigger Evaluation" })).toBeDisabled();
+  });
+
   it("renders configured execution policy metadata", () => {
     const store = createStore();
     const scheduledAt = Date.UTC(2026, 4, 11, 3, 0);