fix(server): align file tree dotfiles with gitignore

Author: pallyoung

packages/server/src/__tests__/fs/gitignore.test.ts

@@ -39,7 +39,7 @@ describe("createGitignoreFilter", () => {
     expect(filter("file.txt")).toBe(true);
     expect(filter("build")).toBe(false);
     expect(filter(".env")).toBe(false);
-    expect(filter(".env.local")).toBe(false);
+    expect(filter(".env.local")).toBe(true);
   });
 
   it("respects negation patterns", async () => {
@@ -60,17 +60,30 @@ describe("createGitignoreFilter", () => {
     expect(filter("root-only.txt")).toBe(true);
   });
 
-  it("keeps default hidden and dependency ignores when .gitignore exists", async () => {
+  it("keeps required repository and dependency ignores when .gitignore exists", async () => {
     await writeFile(join(testDir, ".gitignore"), "*.log");
 
     const filter = createGitignoreFilter(testDir, testDir);
 
     expect(filter(".git")).toBe(false);
-    expect(filter(".hidden")).toBe(false);
+    expect(filter(".hidden")).toBe(true);
+    expect(filter(".gitignore")).toBe(true);
     expect(filter("node_modules")).toBe(false);
     expect(filter("app.log")).toBe(false);
     expect(filter("file.txt")).toBe(true);
   });
+
+  it("shows dotfiles when .gitignore does not ignore them", async () => {
+    await writeFile(join(testDir, ".gitignore"), "*.log\n!.env\n!.gitignore");
+
+    const filter = createGitignoreFilter(testDir, testDir);
+
+    expect(filter(".env")).toBe(true);
+    expect(filter(".gitignore")).toBe(true);
+    expect(filter(".hidden")).toBe(true);
+    expect(filter("node_modules")).toBe(false);
+    expect(filter(".git")).toBe(false);
+  });
 });
 
 describe("createWatcherIgnoreFilter", () => {

packages/server/src/__tests__/fs/tree.test.ts

@@ -136,4 +136,18 @@ describe("readTree", () => {
     expect(result.children.some((n) => n.name === "app.txt")).toBe(true);
     expect(result.children.some((n) => n.name === "src")).toBe(true);
   });
+
+  it("should show dotfiles when .gitignore does not ignore them", async () => {
+    await writeFile(join(testDir, ".gitignore"), "*.log");
+    await writeFile(join(testDir, ".env"), "secret");
+    await writeFile(join(testDir, ".hidden-config"), "hidden");
+    await writeFile(join(testDir, "visible.txt"), "visible");
+
+    const result = await readTree(testDir);
+
+    expect(result.children.some((n) => n.name === ".env")).toBe(true);
+    expect(result.children.some((n) => n.name === ".gitignore")).toBe(true);
+    expect(result.children.some((n) => n.name === ".hidden-config")).toBe(true);
+    expect(result.children.some((n) => n.name === "visible.txt")).toBe(true);
+  });
 });

packages/server/src/fs/gitignore.ts

@@ -25,6 +25,10 @@ function isDefaultTreeIgnored(name: string): boolean {
   return name.startsWith(".") || name === "node_modules" || name === ".git";
 }
 
+function isAlwaysTreeIgnored(name: string): boolean {
+  return name === "node_modules" || name === ".git";
+}
+
 function isIgnoredByGitignore(ig: ReturnType<typeof ignore>, path: string): boolean {
   if (!path || path.startsWith("..")) {
     return false;
@@ -55,7 +59,7 @@ export function createGitignoreFilter(
   const ig = ignore().add(gitignoreContent);
 
   return (name: string) => {
-    if (isDefaultTreeIgnored(name)) {
+    if (isAlwaysTreeIgnored(name)) {
       return false;
     }