Merge pull request #24 from spencerkit/develop

Merge develop into main

Author: pallyoung

.changeset/tidy-icons-sing.md

@@ -0,0 +1,4 @@
+"@spencer-kit/coder-studio": patch
+---
+
+Fix the bundled web favicon assets by regenerating the PNG and ICO files directly from the SVG source so the icon keeps transparent edges without the visible border artifact.

.github/workflows/ci.yml

@@ -47,3 +47,51 @@ jobs:
 
       - name: Run production build
         run: pnpm ci:build
+
+  windows-runtime-verify:
+    name: Windows runtime verification
+    runs-on: windows-latest
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.33.2
+          run_install: false
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "24"
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      # Windows CI now proves that our non-PTY subprocess paths pass `windowsHide: true`
+      # and that provider/session PTY startup still works with the existing cross-platform
+      # argv contract. It does not visually prove the absence of a transient desktop
+      # console flash from node-pty itself; that still requires a manual smoke check on
+      # a real Windows desktop.
+      - name: Run targeted Windows provider tests
+        run: pnpm --filter @coder-studio/providers exec vitest run src/claude/definition.test.ts src/codex/definition.test.ts
+
+      - name: Run targeted Windows server tests
+        run: pnpm --filter @coder-studio/server exec vitest run src/__tests__/provider-runtime/command-check.test.ts src/__tests__/provider-runtime/command-runner.test.ts src/__tests__/provider-runtime/install-manager.test.ts src/__tests__/workspace/runtime-check.test.ts src/git/cli.windows.test.ts src/supervisor/evaluator.windows.test.ts src/__tests__/server-provider-install-wiring.test.ts src/__tests__/session-commands.test.ts src/__tests__/session-integration.test.ts
+
+      - name: Run targeted Windows CLI tests
+        run: pnpm --filter @spencer-kit/coder-studio exec vitest run src/browser.test.ts src/bin.test.ts src/pm2-control.test.ts src/server-control.test.ts
+
+      - name: Build web assets for CLI packaging
+        run: pnpm build:web
+
+      - name: Build server package
+        run: pnpm --filter @coder-studio/server build
+
+      - name: Build CLI package
+        run: pnpm --filter @spencer-kit/coder-studio build

README.md

@@ -10,7 +10,7 @@ Coder Studio lets you launch an AI coding workspace on your machine and keep usi
 
 Start a task in the office, check progress on your phone during the commute, review changes from a tablet, and continue on a laptop later. Same workspace, same context, no environment handoff.
 
-![Workspace](docs/help/assets/screenshot-workspace.png)
+![Workspace](docs/help/assets/screenshot-workspace-overview.png)
 
 ## Why Coder Studio
 

README.zh-CN.md

@@ -10,7 +10,7 @@ Coder Studio 让你把 AI coding workspace 启动在自己的机器上，然后
 
 你可以在办公室发起任务，在通勤路上用手机看进度，在外面用平板审阅改动，回到家再用另一台电脑继续接着做。还是同一个 workspace，还是同一份上下文，不需要重新接管环境。
 
-![工作区界面](docs/help/assets/screenshot-workspace.png)
+![工作区界面](docs/help/assets/screenshot-workspace-overview.png)
 
 ## 为什么是 Coder Studio
 

docs/help/assets/screenshot-workspace-overview.png

@@ -0,0 +1,18 @@
+import { describe, expect, it } from "vitest";
+import { translateForE2E } from "./i18n.js";
+
+describe("translateForE2E", () => {
+  it("defaults to the app default locale for welcome copy", () => {
+    expect(translateForE2E("welcome.kicker")).toBe("开始使用");
+    expect(translateForE2E("action.open_workspace")).toBe("打开工作区");
+  });
+
+  it("can resolve English strings when requested", () => {
+    expect(translateForE2E("welcome.kicker", "en")).toBe("GET STARTED");
+    expect(translateForE2E("workspace.launch.title", "en")).toBe("Open Workspace");
+  });
+
+  it("interpolates variables", () => {
+    expect(translateForE2E("workspace.launch.items_count", "zh", { count: 3 })).toBe("3 项");
+  });
+});

docs/help/assets/screenshot-workspace.png

@@ -0,0 +1,60 @@
+import { readFileSync } from "node:fs";
+
+function readLocale(path: string) {
+  return JSON.parse(readFileSync(new URL(path, import.meta.url), "utf8")) as Record<
+    string,
+    unknown
+  >;
+}
+
+export const E2E_LOCALES = {
+  en: readLocale("../../packages/web/src/locales/en.json"),
+  zh: readLocale("../../packages/web/src/locales/zh.json"),
+} as const;
+
+export type E2ELocaleCode = keyof typeof E2E_LOCALES;
+
+type NestedKeyOf<T> = T extends object
+  ? {
+      [K in keyof T]: K extends string
+        ? T[K] extends object
+          ? `${K}.${NestedKeyOf<T[K]>}`
+          : K
+        : never;
+    }[keyof T]
+  : never;
+
+export type E2ETranslationKey = NestedKeyOf<(typeof E2E_LOCALES)["zh"]>;
+
+function getNestedValue(obj: unknown, path: string): string | undefined {
+  const parts = path.split(".");
+  let current: unknown = obj;
+
+  for (const part of parts) {
+    if (current === null || current === undefined) return undefined;
+    if (typeof current !== "object") return undefined;
+    current = (current as Record<string, unknown>)[part];
+  }
+
+  return typeof current === "string" ? current : undefined;
+}
+
+export function translateForE2E(
+  key: E2ETranslationKey,
+  locale: E2ELocaleCode = "zh",
+  params?: Record<string, string | number>
+): string {
+  let text = getNestedValue(E2E_LOCALES[locale], key);
+
+  if (text === undefined) {
+    throw new Error(`Missing translation for key: ${key}`);
+  }
+
+  if (params) {
+    for (const [name, value] of Object.entries(params)) {
+      text = text.replace(new RegExp(`\\{${name}\\}`, "g"), String(value));
+    }
+  }
+
+  return text;
+}

e2e/fixtures/i18n.test.ts

@@ -0,0 +1,18 @@
+import { expect, type Locator, type Page } from "@playwright/test";
+import { translateForE2E } from "./i18n.js";
+
+export async function expectWelcomeCopy(page: Page): Promise<void> {
+  await expect(page.locator(".welcome-kicker")).toHaveText(translateForE2E("welcome.kicker"));
+  await expect(page.locator(".welcome-title")).toHaveText(translateForE2E("welcome.title"));
+  await expect(page.locator(".welcome-body")).toContainText(translateForE2E("welcome.description"));
+}
+
+export async function expectOpenWorkspaceButton(locator: Locator): Promise<void> {
+  await expect(locator).toBeVisible();
+  await expect(locator.locator("span")).toContainText(translateForE2E("action.open_workspace"));
+}
+
+export async function expectSettingsButton(locator: Locator): Promise<void> {
+  await expect(locator).toBeVisible();
+  await expect(locator.locator("span")).toContainText(translateForE2E("action.settings"));
+}

e2e/fixtures/i18n.ts

@@ -0,0 +1,108 @@
+import { type Page } from "@playwright/test";
+import { type E2ELocaleCode, translateForE2E } from "./i18n.js";
+
+type SettingsSection = "general" | "appearance" | "providers" | "shortcuts";
+type ProviderSettingLabel =
+  | "base"
+  | "config_file"
+  | "open_config_file_editor"
+  | "back_to_base"
+  | "startup_args";
+type SettingsGroupLabel = "notifications" | "theme" | "language";
+type ConfigFileLabel = "claude" | "codex";
+
+const SETTINGS_SECTION_KEYS: Record<SettingsSection, Parameters<typeof translateForE2E>[0]> = {
+  general: "settings.general",
+  appearance: "settings.appearance",
+  providers: "settings.providers",
+  shortcuts: "settings.shortcuts.title",
+};
+
+const PROVIDER_SETTING_KEYS: Record<ProviderSettingLabel, Parameters<typeof translateForE2E>[0]> = {
+  base: "settings.provider.base",
+  config_file: "settings.provider.config_file",
+  open_config_file_editor: "settings.provider.open_config_file_editor",
+  back_to_base: "settings.provider.back_to_base",
+  startup_args: "settings.provider.startup_args",
+};
+
+const SETTINGS_GROUP_KEYS: Record<SettingsGroupLabel, Parameters<typeof translateForE2E>[0]> = {
+  notifications: "settings.notifications",
+  theme: "settings.theme.title",
+  language: "settings.language.title",
+};
+
+const CONFIG_FILE_KEYS: Record<ConfigFileLabel, Parameters<typeof translateForE2E>[0]> = {
+  claude: "settings.config_files.claude_config",
+  codex: "settings.config_files.codex_config",
+};
+
+export const AUTH_PREVIEW_URL = new URL("../../packages/web/auth-preview.html", import.meta.url)
+  .href;
+
+function escapeRegExp(value: string): string {
+  return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+
+function localizedPattern(
+  key: Parameters<typeof translateForE2E>[0],
+  params?: Record<string, string | number>
+): RegExp {
+  const en = translateForE2E(key, "en", params);
+  const zh = translateForE2E(key, "zh", params);
+  const values = [...new Set([en, zh])].map(escapeRegExp);
+  return new RegExp(`^(?:${values.join("|")})$`);
+}
+
+export function settingsSectionLabel(
+  section: SettingsSection,
+  locale: E2ELocaleCode = "zh"
+): string {
+  return translateForE2E(SETTINGS_SECTION_KEYS[section], locale);
+}
+
+export function settingsSectionPattern(section: SettingsSection): RegExp {
+  return localizedPattern(SETTINGS_SECTION_KEYS[section]);
+}
+
+export async function openSettingsSection(
+  page: Page,
+  section: SettingsSection,
+  locale?: E2ELocaleCode
+): Promise<void> {
+  await page
+    .getByRole("button", {
+      name: locale ? settingsSectionLabel(section, locale) : settingsSectionPattern(section),
+    })
+    .click();
+}
+
+export function providerSettingLabel(
+  label: ProviderSettingLabel,
+  locale: E2ELocaleCode = "zh"
+): string {
+  return translateForE2E(PROVIDER_SETTING_KEYS[label], locale);
+}
+
+export function providerSettingPattern(label: ProviderSettingLabel): RegExp {
+  return localizedPattern(PROVIDER_SETTING_KEYS[label]);
+}
+
+export function settingsGroupLabel(
+  label: SettingsGroupLabel,
+  locale: E2ELocaleCode = "zh"
+): string {
+  return translateForE2E(SETTINGS_GROUP_KEYS[label], locale);
+}
+
+export function settingsGroupPattern(label: SettingsGroupLabel): RegExp {
+  return localizedPattern(SETTINGS_GROUP_KEYS[label]);
+}
+
+export function configFileLabel(label: ConfigFileLabel, locale: E2ELocaleCode = "zh"): string {
+  return translateForE2E(CONFIG_FILE_KEYS[label], locale);
+}
+
+export function configFilePattern(label: ConfigFileLabel): RegExp {
+  return localizedPattern(CONFIG_FILE_KEYS[label]);
+}