fix: preserve terminal copy-on-select sync on stale loads

Author: pallyoung

packages/web/src/features/settings/components/settings-page.test.tsx

@@ -1118,6 +1118,7 @@ describe("SettingsPage", () => {
       "aria-checked",
       "true"
     );
+    expect(store.get(terminalPreferencesAtom)).toEqual({ copyOnSelect: true });
   });
 
   it("updates language selection through the shared appearance pills", async () => {

packages/web/src/features/settings/components/settings-page.tsx

@@ -240,13 +240,21 @@ export function SettingsPage() {
           setTerminalRendererState(settings["appearance.terminalRenderer"]);
         }
       }
+      const resolvedTerminalCopyOnSelect = resolveTerminalCopyOnSelectSetting(settings);
       if (typeof settings["appearance.terminalCopyOnSelect"] === "boolean") {
         if (
           appearanceSelectionVersionRef.current.terminalCopyOnSelect ===
           appearanceSelectionVersionAtRequestStart.terminalCopyOnSelect
         ) {
           setTerminalCopyOnSelectState(settings["appearance.terminalCopyOnSelect"]);
+          setTerminalPreferences({
+            copyOnSelect: resolvedTerminalCopyOnSelect,
+          });
         }
+      } else {
+        setTerminalPreferences({
+          copyOnSelect: resolvedTerminalCopyOnSelect,
+        });
       }
       if (settings["appearance.locale"] === "zh" || settings["appearance.locale"] === "en") {
         if (
@@ -256,9 +264,6 @@ export function SettingsPage() {
           setLocaleState(settings["appearance.locale"]);
         }
       }
-      setTerminalPreferences({
-        copyOnSelect: resolveTerminalCopyOnSelectSetting(settings),
-      });
       setProviderAdditionalArgsById(loadProviderAdditionalArgs(settings, providers));
     };