Skip to content

Commit 4b73155

Browse files
committed
fix(web): distinguish workspace git footer icons
1 parent fe9ba07 commit 4b73155

2 files changed

Lines changed: 17 additions & 4 deletions

File tree

packages/web/src/theme/icon-theme.test.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,13 @@ describe("theme icon resolver", () => {
4040
expect(hcFolder.Icon).not.toBeUndefined();
4141
expect(mintFolder.strokeWidth).not.toBe(hcFolder.strokeWidth);
4242
});
43+
44+
it("uses distinct glyphs for footer git action semantics", () => {
45+
const diffIcon = getIconPresentation("mint-dark", "git.action.diff").Icon;
46+
const pushIcon = getIconPresentation("mint-dark", "git.action.push").Icon;
47+
const pullIcon = getIconPresentation("mint-dark", "git.action.pull").Icon;
48+
const refreshIcon = getIconPresentation("mint-dark", "git.action.refresh").Icon;
49+
50+
expect(new Set([diffIcon, pushIcon, pullIcon, refreshIcon]).size).toBe(4);
51+
});
4352
});

packages/web/src/theme/icon-theme.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import {
33
AlertTriangle,
44
ArrowUpCircle,
55
Bot,
6+
Download,
67
Eye,
78
File,
89
FileCode2,
@@ -13,6 +14,7 @@ import {
1314
FolderOpen,
1415
FolderPlus,
1516
GitBranch,
17+
GitCompare,
1618
Globe,
1719
House,
1820
Image as ImageIcon,
@@ -26,11 +28,13 @@ import {
2628
Play,
2729
Plus,
2830
PowerOff,
31+
RotateCcw,
2932
Search,
3033
Settings,
3134
Sparkles,
3235
Terminal,
3336
TriangleAlert,
37+
Upload,
3438
Zap,
3539
} from "lucide-react";
3640

@@ -157,10 +161,10 @@ export const BASE_ICON_THEME: IconThemeDefinition = {
157161
"git.status.modified": { glyph: GitBranch, tone: "git-modified" },
158162
"git.status.deleted": { glyph: TriangleAlert, tone: "git-deleted" },
159163
"git.status.untracked": { glyph: Plus, tone: "git-untracked" },
160-
"git.action.diff": { glyph: GitBranch, tone: "secondary" },
161-
"git.action.pull": { glyph: GitBranch, tone: "secondary" },
162-
"git.action.push": { glyph: GitBranch, tone: "secondary" },
163-
"git.action.refresh": { glyph: GitBranch, tone: "secondary" },
164+
"git.action.diff": { glyph: GitCompare, tone: "secondary" },
165+
"git.action.pull": { glyph: Download, tone: "secondary" },
166+
"git.action.push": { glyph: Upload, tone: "secondary" },
167+
"git.action.refresh": { glyph: RotateCcw, tone: "secondary" },
164168
"git.action.warning": { glyph: AlertTriangle, tone: "warning" },
165169
"git.branch": { glyph: GitBranch, tone: "secondary" },
166170
"git.branch.create": { glyph: Plus, tone: "secondary" },

0 commit comments

Comments
 (0)