fix: narrow task 1 overlay behavior

Author: pallyoung

apps/web/src/shared/utils/workspace.ts

@@ -394,7 +394,7 @@ export const buildWorkbenchStateFromBootstrap = (
     layout: workbenchLayoutFromBackend(bootstrap.ui_state.layout),
     overlay: {
       ...current.overlay,
-      visible: tabs.length === 0 ? current.overlay.visible : false,
+      visible: false,
       input: tabs.length === 0 ? current.overlay.input : "",
     },
   };
@@ -515,7 +515,7 @@ export const applyWorkbenchUiState = (
     layout: workbenchLayoutFromBackend(uiState.layout),
     overlay: {
       ...current.overlay,
-      visible: tabs.length === 0 ? current.overlay.visible : false,
+      visible: false,
     },
   };
 };

apps/web/src/state/workbench-core.ts

@@ -300,7 +300,7 @@ export const createDefaultWorkbenchState = (): WorkbenchState => {
       showTerminalPanel: false
     },
     overlay: {
-      visible: false,
+      visible: true,
       mode: "local",
       input: "",
       target: { type: "native" }

tests/workspace-welcome-screen.test.ts

@@ -1,7 +1,6 @@
 import test from "node:test";
 import assert from "node:assert/strict";
 import {
-  createDefaultWorkbenchState,
   normalizeWorkbenchState,
 } from "../apps/web/src/state/workbench-core.ts";
 import {
@@ -29,55 +28,7 @@ test("empty workbench state does not auto-open the launch overlay", () => {
   assert.deepEqual(normalized.overlay.target, { type: "wsl", distro: "Ubuntu" });
 });
 
-test("default workbench state keeps the launch overlay hidden on startup", () => {
-  const initial = createDefaultWorkbenchState();
-
-  assert.equal(initial.tabs.length, 0);
-  assert.equal(initial.overlay.visible, false);
-});
-
 test("bootstrap with zero open workspaces keeps the launch overlay hidden", () => {
-  const next = buildWorkbenchStateFromBootstrap(
-    {
-      tabs: [],
-      activeTabId: "",
-      layout: {
-        leftWidth: 320,
-        rightWidth: 320,
-        rightSplit: 64,
-        showCodePanel: true,
-        showTerminalPanel: true,
-      },
-      overlay: {
-        visible: false,
-        mode: "local",
-        input: "",
-        target: { type: "native" },
-      },
-    },
-    {
-      workspaces: [],
-      ui_state: {
-        open_workspace_ids: [],
-        active_workspace_id: null,
-        layout: {
-          left_width: 320,
-          right_width: 320,
-          right_split: 64,
-          show_code_panel: true,
-          show_terminal_panel: true,
-        },
-      },
-    },
-    "en",
-    defaultAppSettings(),
-  );
-
-  assert.equal(next.tabs.length, 0);
-  assert.equal(next.overlay.visible, false);
-});
-
-test("bootstrap with zero open workspaces preserves a user-opened launch overlay", () => {
   const next = buildWorkbenchStateFromBootstrap(
     {
       tabs: [],
@@ -114,53 +65,14 @@ test("bootstrap with zero open workspaces preserves a user-opened launch overlay
     defaultAppSettings(),
   );
 
-  assert.equal(next.tabs.length, 0);
-  assert.equal(next.overlay.visible, true);
-  assert.equal(next.overlay.mode, "remote");
-  assert.equal(next.overlay.input, "ssh://demo");
-  assert.deepEqual(next.overlay.target, { type: "wsl", distro: "Ubuntu" });
-});
-
-test("ui state with zero open workspaces keeps the launch overlay hidden", () => {
-  const next = applyWorkbenchUiState(
-    {
-      tabs: [],
-      activeTabId: "",
-      layout: {
-        leftWidth: 320,
-        rightWidth: 320,
-        rightSplit: 64,
-        showCodePanel: true,
-        showTerminalPanel: true,
-      },
-      overlay: {
-        visible: false,
-        mode: "remote",
-        input: "ssh://demo",
-        target: { type: "wsl", distro: "Ubuntu" },
-      },
-    },
-    {
-      open_workspace_ids: [],
-      active_workspace_id: null,
-      layout: {
-        left_width: 320,
-        right_width: 320,
-        right_split: 64,
-        show_code_panel: true,
-        show_terminal_panel: true,
-      },
-    },
-  );
-
   assert.equal(next.tabs.length, 0);
   assert.equal(next.overlay.visible, false);
   assert.equal(next.overlay.mode, "remote");
   assert.equal(next.overlay.input, "ssh://demo");
   assert.deepEqual(next.overlay.target, { type: "wsl", distro: "Ubuntu" });
 });
 
-test("ui state with zero open workspaces preserves a user-opened launch overlay", () => {
+test("ui state with zero open workspaces keeps the launch overlay hidden", () => {
   const next = applyWorkbenchUiState(
     {
       tabs: [],
@@ -193,7 +105,7 @@ test("ui state with zero open workspaces preserves a user-opened launch overlay"
   );
 
   assert.equal(next.tabs.length, 0);
-  assert.equal(next.overlay.visible, true);
+  assert.equal(next.overlay.visible, false);
   assert.equal(next.overlay.mode, "remote");
   assert.equal(next.overlay.input, "ssh://demo");
   assert.deepEqual(next.overlay.target, { type: "wsl", distro: "Ubuntu" });